Put manufacturer distinction into ipxe script

Author: simcod

pixiecore/boot.ipxe

@@ -23,6 +23,14 @@ echo metal-stack pixie
 
 echo Manufacturer: ${manufacturer}
 
+# Detect serial console based on manufacturer.
+# Implicitly ttyS1 is used as console for Supermicro.
+
+set console ttyS1
+set sp:hex 20 && set sp ${sp:string}
+iseq ${manufacturer} Dell${sp}Inc. && set console ttyS0 ||
+iseq ${manufacturer} Giga${sp}Computing && set console ttyS0 ||
+
 # Try to get a filename from ProxyDHCP, retrying a couple of times if
 # we fail.
 :loop

pixiecore/http.go

@@ -196,10 +196,6 @@ func ipxeScript(mach Machine, spec *Spec, serverHost string) ([]byte, error) {
 	urlTemplate := fmt.Sprintf("http://%s/_/file?name=%%s&type=%%s&mac=%%s", serverHost)
 	var b bytes.Buffer
 	b.WriteString("#!ipxe\n")
-	b.WriteString("set console ttyS1\n")
-	b.WriteString("set sp:hex 20 && set sp ${sp:string}\n")
-	b.WriteString("iseq ${manufacturer} Dell${sp}Inc. && set console ttyS0 ||\n")
-	b.WriteString("iseq ${manufacturer} Giga${sp}Computing && set console ttyS0 ||\n")
 	u := fmt.Sprintf(urlTemplate, url.QueryEscape(string(spec.Kernel)), "kernel", url.QueryEscape(mach.MAC.String()))
 	fmt.Fprintf(&b, "kernel --name kernel %s\n", u)
 	for i, initrd := range spec.Initrd {
@@ -218,7 +214,6 @@ func ipxeScript(mach Machine, spec *Spec, serverHost string) ([]byte, error) {
 	f := func(id string) string {
 		return fmt.Sprintf("http://%s/_/file?name=%s", serverHost, url.QueryEscape(id))
 	}
-
 	cmdline, err := expandCmdline(spec.Cmdline, template.FuncMap{"ID": f})
 	if err != nil {
 		return nil, fmt.Errorf("expanding cmdline %q: %w", spec.Cmdline, err)

pixiecore/http_test.go

@@ -66,10 +66,6 @@ func TestIpxe(t *testing.T) {
 	}
 
 	expected := `#!ipxe
-set console ttyS1
-set sp:hex 20 && set sp ${sp:string}
-iseq ${manufacturer} Dell${sp}Inc. && set console ttyS0 ||
-iseq ${manufacturer} Giga${sp}Computing && set console ttyS0 ||
 kernel --name kernel http://localhost:1234/_/file?name=k-01%3A02%3A03%3A04%3A05%3A06-0&type=kernel&mac=01%3A02%3A03%3A04%3A05%3A06
 initrd --name initrd0 http://localhost:1234/_/file?name=i1-01%3A02%3A03%3A04%3A05%3A06-0&type=initrd&mac=01%3A02%3A03%3A04%3A05%3A06
 initrd --name initrd1 http://localhost:1234/_/file?name=i2-01%3A02%3A03%3A04%3A05%3A06-0&type=initrd&mac=01%3A02%3A03%3A04%3A05%3A06
@@ -95,10 +91,6 @@ boot kernel initrd=initrd0 initrd=initrd1 console=${console},115200n8 thing=http
 	}
 
 	expected = `#!ipxe
-set console ttyS1
-set sp:hex 20 && set sp ${sp:string}
-iseq ${manufacturer} Dell${sp}Inc. && set console ttyS0 ||
-iseq ${manufacturer} Giga${sp}Computing && set console ttyS0 ||
 kernel --name kernel http://localhost:1234/_/file?name=k-fe%3Afe%3Afe%3Afe%3Afe%3Afe-1&type=kernel&mac=fe%3Afe%3Afe%3Afe%3Afe%3Afe
 initrd --name initrd0 http://localhost:1234/_/file?name=i1-fe%3Afe%3Afe%3Afe%3Afe%3Afe-1&type=initrd&mac=fe%3Afe%3Afe%3Afe%3Afe%3Afe
 initrd --name initrd1 http://localhost:1234/_/file?name=i2-fe%3Afe%3Afe%3Afe%3Afe%3Afe-1&type=initrd&mac=fe%3Afe%3Afe%3Afe%3Afe%3Afe