Added support for Promises in #with (closes #469).
#471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankapunkt
approved these changes
Sep 13, 2024
|
Generally approve, however I can't understand why tests do fail. Here is a snipped from the circleci run:
This looks like nothing related to this PR 🤔 |
|
Interesting... They all passed locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #469 (comment), this PR adds support for
Promises in#withblocks, just like #424 did that for#ifand#each.Note that due to the way
#withis implemented, it takes two "cycles" (i.e.,awaits) to fully propagate those results. That should not be a problem, as#withis discouraged anyway.