Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: drop aiofiles dependency #2746

Open
oliver-sanders opened this issue Dec 8, 2023 · 0 comments
Open

deps: drop aiofiles dependency #2746

oliver-sanders opened this issue Dec 8, 2023 · 0 comments
Milestone

Comments

@oliver-sanders
Copy link
Member

We are using aiofiles to facilitate asynchronous IO.

The way aiofiles achieves this is by wrapping IO functions with a decorator which causes them to be run in a ThreadPoolExecutor. The decorator they use can be found here:

https://github.com/Tinche/aiofiles/blob/213ee8b325e09bb6026c2495cf5810023f342f3f/src/aiofiles/ospath.py#L7-L15

In Cylc we use a similar decorator to wrap a couple of functions:

https://github.com/cylc/cylc-flow/blob/994b774f9562f8ee606c37c3ffe1a76df0e5f61b/cylc/flow/async_util.py#L463-L477

This avoids the need for the aiofiles dependency.

@oliver-sanders oliver-sanders added this to the 2.x milestone Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant