Handle URL-encoded paths in file and resource handlers

Author: Miikka Koskinen

dev-resources/public/with space.txt

@@ -0,0 +1 @@
+hello

modules/reitit-ring/src/reitit/ring.cljc

@@ -222,12 +222,12 @@
                                               (recur files))))))
            handler (if path
                      (fn [request]
-                       (let [uri (:uri request)]
+                       (let [uri (impl/url-decode (:uri request))]
                          (if (str/starts-with? uri path)
                            (or (path-or-index-response (subs uri path-size) uri)
                                (not-found-handler request)))))
                      (fn [request]
-                       (let [uri (:uri request)
+                       (let [uri (impl/url-decode (:uri request))
                              path (-> request :path-params parameter)]
                          (or (path-or-index-response path uri)
                              (not-found-handler request)))))]

test/cljc/reitit/ring_test.cljc

@@ -471,9 +471,9 @@
 
              (testing "from root"
                (let [app (ring/ring-handler
-                           (ring/router
-                             ["/*" (create nil)])
-                           (ring/create-default-handler))]
+                          (ring/router
+                           ["/*" (create nil)])
+                          (ring/create-default-handler))]
                  (testing "different file-types"
                    (let [response (app (request "/hello.json"))]
                      (is (= "application/json" (get-in response [:headers "Content-Type"])))
@@ -484,6 +484,11 @@
                      (is (get-in response [:headers "Last-Modified"]))
                      (is (= "<xml><hello>file</hello></xml>\n" (slurp (:body response))))))
 
+                 (testing "with url decoding"
+                   (let [response (app (request "/with%20space.txt"))]
+                     (is (= 200 (:status response)))
+                     (is (= "hello\n" (slurp (:body response))))))
+
                  (testing "index-files"
                    (let [response (app (request "/docs"))]
                      (is (= (redirect "/docs/index.html") response)))
@@ -520,6 +525,11 @@
                      (is (get-in response [:headers "Last-Modified"]))
                      (is (= "<xml><hello>file</hello></xml>\n" (slurp (:body response))))))
 
+                 (testing "with url decoding"
+                   (let [response (app (request "/with%20space.txt"))]
+                     (is (= 200 (:status response)))
+                     (is (= "hello\n" (slurp (:body response))))))
+
                  (testing "index-files"
                    (let [response (app (request "/docs"))]
                      (is (= (redirect "/docs/index.html") response)))
@@ -557,6 +567,11 @@
                      (is (get-in response [:headers "Last-Modified"]))
                      (is (= "<xml><hello>file</hello></xml>\n" (slurp (:body response))))))
 
+                 (testing "with url decoding"
+                   (let [response (app (request "/with%20space.txt"))]
+                     (is (= 200 (:status response)))
+                     (is (= "hello\n" (slurp (:body response))))))
+
                  (testing "index-files"
                    (let [response (app (request "/docs"))]
                      (is (= (redirect "/docs/index.html") response)))
@@ -595,6 +610,11 @@
                      (is (get-in response [:headers "Last-Modified"]))
                      (is (= "<xml><hello>file</hello></xml>\n" (slurp (:body response))))))
 
+                 (testing "with url decoding"
+                   (let [response (app (request "/with%20space.txt"))]
+                     (is (= 200 (:status response)))
+                     (is (= "hello\n" (slurp (:body response))))))
+
                  (testing "index-files"
                    (let [response (app (request "/docs"))]
                      (is (= (redirect "/docs/index.html") response)))