Add clj-kondo and fix most linting warnings

Author: Deraen

.clj-kondo/config.edn

@@ -0,0 +1,6 @@
+{;;:skip-comments true
+ :lint-as {potemkin/def-derived-map clojure.core/defrecord}
+ :linters {:if {:level :off}
+           :unused-binding {:level :off}
+           :unused-referred-var {:exclude {clojure.test [deftest testing is are]
+                                           cljs.test [deftest testing is are]}}}}

Justfile

@@ -0,0 +1,10 @@
+help:
+    @just --list
+
+# Initializes lint
+init-lint:
+    clj-kondo --lint $(lein classpath)
+
+# Lints the project
+lint:
+    ./lint.sh

examples/frontend-auth/src/backend/server.clj

@@ -1,6 +1,5 @@
 (ns backend.server
-  (:require [clojure.java.io :as io]
-            [ring.util.response :as resp]
+  (:require [ring.util.response :as resp]
             [ring.middleware.content-type :as content-type]))
 
 (def handler

examples/frontend-auth/src/frontend/core.cljs

@@ -3,7 +3,6 @@
               [reitit.frontend :as rf]
               [reitit.frontend.easy :as rfe]
               [reitit.frontend.controllers :as rfc]
-              [reitit.coercion :as rc]
               [reitit.coercion.schema :as rsc]
               [schema.core :as s]
               [fipp.edn :as fedn]))

examples/frontend-controllers/src/backend/server.clj

@@ -1,6 +1,5 @@
 (ns backend.server
-  (:require [clojure.java.io :as io]
-            [ring.util.response :as resp]
+  (:require [ring.util.response :as resp]
             [ring.middleware.content-type :as content-type]))
 
 (def handler

examples/frontend-controllers/src/frontend/core.cljs

@@ -3,7 +3,6 @@
               [reitit.frontend :as rf]
               [reitit.frontend.easy :as rfe]
               [reitit.frontend.controllers :as rfc]
-              [reitit.coercion :as rc]
               [reitit.coercion.schema :as rsc]
               [schema.core :as s]
               [fipp.edn :as fedn]))

examples/frontend-links/src/backend/server.clj

@@ -1,6 +1,5 @@
 (ns backend.server
-  (:require [clojure.java.io :as io]
-            [ring.util.response :as resp]
+  (:require [ring.util.response :as resp]
             [ring.middleware.content-type :as content-type]))
 
 (def handler

examples/frontend-links/src/frontend/core.cljs

@@ -2,7 +2,6 @@
   (:require [clojure.string :as string]
             [fipp.edn :as fedn]
             [reagent.core :as r]
-            [reitit.coercion :as rc]
             [reitit.coercion.spec :as rss]
             [reitit.frontend :as rf]
             [reitit.frontend.easy :as rfe]

examples/frontend-prompt/src/backend/server.clj

@@ -1,6 +1,5 @@
 (ns backend.server
-  (:require [clojure.java.io :as io]
-            [ring.util.response :as resp]
+  (:require [ring.util.response :as resp]
             [ring.middleware.content-type :as content-type]))
 
 (def handler

examples/frontend-prompt/src/frontend/core.cljs

@@ -1,11 +1,9 @@
 (ns frontend.core
   (:require [fipp.edn :as fedn]
             [reagent.core :as r]
-            [reitit.coercion :as rc]
             [reitit.coercion.spec :as rss]
             [reitit.frontend :as rf]
-            [reitit.frontend.easy :as rfe]
-            [spec-tools.data-spec :as ds]))
+            [reitit.frontend.easy :as rfe]))
 
 ;; Implementing conditional prompt on navigation with Reitit frontend.
 

examples/frontend-re-frame/src/clj/backend/server.clj

@@ -1,6 +1,5 @@
 (ns backend.server
-  (:require [clojure.java.io :as io]
-            [ring.util.response :as resp]
+  (:require [ring.util.response :as resp]
             [ring.middleware.content-type :as content-type]))
 
 (def handler

examples/frontend-re-frame/src/cljs/frontend_re_frame/core.cljs

@@ -1,13 +1,11 @@
 (ns frontend-re-frame.core
-  (:require
-   [re-frame.core :as re-frame]
-   [reagent.core :as reagent]
-   [reitit.core :as r]
-   [reitit.coercion :as rc]
-   [reitit.coercion.spec :as rss]
-   [reitit.frontend :as rf]
-   [reitit.frontend.controllers :as rfc]
-   [reitit.frontend.easy :as rfe]))
+  (:require [re-frame.core :as re-frame]
+            [reagent.core :as reagent]
+            [reitit.core :as r]
+            [reitit.coercion.spec :as rss]
+            [reitit.frontend :as rf]
+            [reitit.frontend.controllers :as rfc]
+            [reitit.frontend.easy :as rfe]))
 
 ;;; Events ;;;
 

examples/frontend/src/backend/server.clj

@@ -1,6 +1,5 @@
 (ns backend.server
-  (:require [clojure.java.io :as io]
-            [ring.util.response :as resp]
+  (:require [ring.util.response :as resp]
             [ring.middleware.content-type :as content-type]))
 
 (def handler

examples/frontend/src/frontend/core.cljs

@@ -2,7 +2,6 @@
   (:require [reagent.core :as r]
             [reitit.frontend :as rf]
             [reitit.frontend.easy :as rfe]
-            [reitit.coercion :as rc]
             [reitit.coercion.spec :as rss]
             [spec-tools.data-spec :as ds]
             [fipp.edn :as fedn]))

examples/http-swagger/src/example/server.clj

@@ -11,9 +11,10 @@
             [reitit.http.interceptors.muuntaja :as muuntaja]
             [reitit.http.interceptors.exception :as exception]
             [reitit.http.interceptors.multipart :as multipart]
-            [reitit.http.interceptors.dev :as dev]
-            [reitit.http.spec :as spec]
-            [spec-tools.spell :as spell]
+            ;; Uncomment to use
+            ; [reitit.http.interceptors.dev :as dev]
+            ; [reitit.http.spec :as spec]
+            ; [spec-tools.spell :as spell]
             [ring.adapter.jetty :as jetty]
             [aleph.http :as aleph]
             [muuntaja.core :as m]

examples/pedestal-swagger/src/example/server.clj

@@ -11,10 +11,10 @@
             [reitit.http.interceptors.muuntaja :as muuntaja]
             [reitit.http.interceptors.exception :as exception]
             [reitit.http.interceptors.multipart :as multipart]
-            [reitit.http.interceptors.dev :as dev]
-            [reitit.http.spec :as spec]
-            [spec-tools.spell :as spell]
-            [io.pedestal.http :as server]
+            ;; Uncomment to use
+            ; [reitit.http.interceptors.dev :as dev]
+            ; [reitit.http.spec :as spec]
+            ; [spec-tools.spell :as spell]
             [reitit.pedestal :as pedestal]
             [clojure.core.async :as a]
             [clojure.java.io :as io]

examples/ring-malli-swagger/test/example/server_test.clj

@@ -1,5 +1,5 @@
 (ns example.server-test
-  (:require [clojure.test :refer :all]
+  (:require [clojure.test :refer [deftest testing is]]
             [example.server :refer [app]]
             [ring.mock.request :refer [request json-body]]))
 

examples/ring-spec-swagger/src/example/server.clj

@@ -9,9 +9,10 @@
             [reitit.ring.middleware.exception :as exception]
             [reitit.ring.middleware.multipart :as multipart]
             [reitit.ring.middleware.parameters :as parameters]
-            [reitit.ring.middleware.dev :as dev]
-            [reitit.ring.spec :as spec]
-            [spec-tools.spell :as spell]
+            ;; Uncomment to use
+            ; [reitit.ring.middleware.dev :as dev]
+            ; [reitit.ring.spec :as spec]
+            ; [spec-tools.spell :as spell]
             [ring.adapter.jetty :as jetty]
             [muuntaja.core :as m]
             [clojure.spec.alpha :as s]

examples/ring-spec-swagger/test/example/server_test.clj

@@ -1,5 +1,5 @@
 (ns example.server-test
-  (:require [clojure.test :refer :all]
+  (:require [clojure.test :refer [deftest testing is]]
             [example.server :refer [app]]
             [ring.mock.request :refer [request json-body]]))
 

examples/ring-swagger/src/example/server.clj

@@ -9,9 +9,10 @@
             [reitit.ring.middleware.exception :as exception]
             [reitit.ring.middleware.multipart :as multipart]
             [reitit.ring.middleware.parameters :as parameters]
-            [reitit.ring.middleware.dev :as dev]
-            [reitit.ring.spec :as spec]
-            [spec-tools.spell :as spell]
+            ;; Uncomment to use
+            ; [reitit.ring.middleware.dev :as dev]
+            ; [reitit.ring.spec :as spec]
+            ; [spec-tools.spell :as spell]
             [ring.adapter.jetty :as jetty]
             [muuntaja.core :as m]
             [clojure.java.io :as io]))

lint.sh

@@ -0,0 +1,15 @@
+#!/bin/bash
+
+EXIT=0
+
+clj-kondo --lint modules/*/src test perf-test
+EXIT=$(( EXIT + $? ))
+
+for file in examples/*/src; do
+    echo
+    echo "Linting $file"
+    clj-kondo --lint "$file"
+    EXIT=$(( EXIT + $? ))
+done
+
+exit $EXIT

modules/reitit-core/src/reitit/impl.cljc

@@ -4,11 +4,9 @@
             [clojure.set :as set]
             [meta-merge.core :as mm]
             [reitit.trie :as trie]
-            [reitit.exception :as exception]
             [reitit.exception :as ex])
   #?(:clj
-     (:import (java.util.regex Pattern)
-              (java.util HashMap Map)
+     (:import (java.util HashMap Map)
               (java.net URLEncoder URLDecoder))))
 
 (defn parse [path opts]
@@ -138,7 +136,7 @@
   (when-not (every? #(contains? path-params %) required)
     (let [defined (-> path-params keys set)
           missing (set/difference required defined)]
-      (exception/fail!
+      (ex/fail!
         (str "missing path-params for route " template " -> " missing)
         {:path-params path-params, :required required}))))
 

modules/reitit-dev/src/reitit/dev/pretty.cljc

@@ -4,7 +4,6 @@
             [reitit.exception :as exception]
             [arrangement.core]
     ;; spell-spec
-            [spec-tools.spell :as spell]
             [spell-spec.expound]
     ;; expound
             [expound.ansi]

modules/reitit-frontend/src/reitit/frontend.cljs

@@ -1,20 +1,19 @@
 (ns reitit.frontend
   (:require [clojure.set :as set]
             [reitit.coercion :as coercion]
-            [reitit.coercion :as rc]
             [reitit.core :as r])
   (:import goog.Uri
            goog.Uri.QueryData))
 
-(defn- query-param [^goog.Uri.QueryData q k]
+(defn- query-param [^QueryData q k]
   (let [vs (.getValues q k)]
     (if (< (alength vs) 2)
       (aget vs 0)
       (vec vs))))
 
 (defn query-params
   "Given goog.Uri, read query parameters into Clojure map."
-  [^goog.Uri uri]
+  [^Uri uri]
   (let [q (.getQueryData uri)]
     (->> q
          (.getKeys)
@@ -51,7 +50,7 @@
   ([raw-routes]
    (router raw-routes {}))
   ([raw-routes opts]
-   (r/router raw-routes (merge {:compile rc/compile-request-coercers} opts))))
+   (r/router raw-routes (merge {:compile coercion/compile-request-coercers} opts))))
 
 (defn match-by-name!
   "Logs problems using console.warn"

modules/reitit-frontend/src/reitit/frontend/history.cljs

@@ -2,7 +2,6 @@
   "Provides integration to hash-change or HTML5 History
   events."
   (:require [reitit.core :as reitit]
-            [reitit.core :as r]
             [reitit.frontend :as rf]
             [goog.events :as gevents])
   (:import goog.Uri))
@@ -59,9 +58,10 @@
           el
           (recur (.-parentNode el)))))))
 
-(defn- event-target [event]
+(defn- event-target
   "Read event's target from composed path to get shadow dom working,
-   fallback to target property if not available"
+  fallback to target property if not available"
+  [event]
   (let [original-event (.getBrowserEvent event)]
     (if (exists? (.-composedPath original-event))
       (aget (.composedPath original-event) 0)
@@ -176,7 +176,7 @@
    (href history k params nil))
   ([history k params query]
    (let [match (rf/match-by-name! (:router history) k params)]
-     (-href history (r/match->path match query)))))
+     (-href history (reitit/match->path match query)))))
 
 (defn push-state
   "Sets the new route, leaving previous route in history."
@@ -186,7 +186,7 @@
    (push-state history k params nil))
   ([history k params query]
    (let [match (rf/match-by-name! (:router history) k params)
-         path (r/match->path match query)]
+         path (reitit/match->path match query)]
      ;; pushState and replaceState don't trigger popstate event so call on-navigate manually
      (.pushState js/window.history nil "" (-href history path))
      (-on-navigate history path))))
@@ -199,6 +199,6 @@
    (replace-state history k params nil))
   ([history k params query]
    (let [match (rf/match-by-name! (:router history) k params)
-         path (r/match->path match query)]
+         path (reitit/match->path match query)]
      (.replaceState js/window.history nil "" (-href history path))
      (-on-navigate history path))))

modules/reitit-http/src/reitit/http/coercion.cljc

@@ -43,9 +43,9 @@
                 (let [coercers (coercion/response-coercers coercion responses opts)]
                   {:leave (fn [ctx]
                             (let [request (:request ctx)
-                                  response (:response ctx)]
-                              (let [response (coercion/coerce-response coercers request response)]
-                                (assoc ctx :response response))))})))})
+                                  response (:response ctx)
+                                  response (coercion/coerce-response coercers request response)]
+                              (assoc ctx :response response)))})))})
 
 (defn coerce-exceptions-interceptor
   "Interceptor for handling coercion exceptions.

modules/reitit-swagger-ui/src/reitit/swagger_ui.cljc

@@ -1,8 +1,6 @@
 (ns reitit.swagger-ui
-  (:require [clojure.string :as str]
-            [reitit.ring :as ring]
-    #?@(:clj [
-            [jsonista.core :as j]])))
+  #?(:clj (:require [reitit.ring :as ring]
+                    [jsonista.core :as j])))
 
 #?(:clj
    (defn create-swagger-ui-handler

modules/reitit-swagger/src/reitit/swagger.cljc

@@ -67,9 +67,10 @@
 (defn- swagger-path [path opts]
   (-> path (trie/normalize opts) (str/replace #"\{\*" "{")))
 
-(defn create-swagger-handler []
+(defn create-swagger-handler
   "Create a ring handler to emit swagger spec. Collects all routes from router which have
   an intersecting `[:swagger :id]` and which are not marked with `:no-doc` route data."
+  []
   (fn create-swagger
     ([{::r/keys [router match] :keys [request-method]}]
      (let [{:keys [id] :or {id ::default} :as swagger} (-> match :result request-method :data :swagger)
@@ -95,11 +96,11 @@
                                      (strip-top-level-keys swagger))]))
            transform-path (fn [[p _ c]]
                             (if-let [endpoint (some->> c (keep transform-endpoint) (seq) (into {}))]
-                              [(swagger-path p (r/options router)) endpoint]))]
-       (let [map-in-order #(->> % (apply concat) (apply array-map))
-             paths (->> router (r/compiled-routes) (filter accept-route) (map transform-path) map-in-order)]
-         {:status 200
-          :body (meta-merge swagger {:paths paths})})))
+                              [(swagger-path p (r/options router)) endpoint]))
+           map-in-order #(->> % (apply concat) (apply array-map))
+           paths (->> router (r/compiled-routes) (filter accept-route) (map transform-path) map-in-order)]
+       {:status 200
+        :body (meta-merge swagger {:paths paths})}))
     ([req res raise]
      (try
        (res (create-swagger req))

perf-test/clj/reitit/bide_perf_test.clj

@@ -1,7 +1,7 @@
 (ns reitit.bide-perf-test
   (:require [criterium.core :as cc]
             [reitit.core :as reitit]
-            [reitit.perf-utils :refer :all]
+            [reitit.perf-utils :refer [suite title]]
 
             [bidi.bidi :as bidi]
             [ataraxy.core :as ataraxy]