ci: removed tags from the arc deploy script

Author: meza

.github/workflows/deploy.yml

@@ -43,13 +43,13 @@ jobs:
         run: pnpm build
       - name: 📦 Deploy Production
         if: github.ref_name == 'main'
-        run: pnpm exec arc deploy --production --name main -t production -v
+        run: pnpm exec arc deploy --production --name main -v
         env:
           AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
           AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
       - name: 📦 Deploy ${{ github.ref_name }}
         if: github.ref_name != 'main'
-        run: pnpm exec arc deploy --name ${{ github.ref_name }} -t ${{ github.ref_name }} -v
+        run: pnpm exec arc deploy --name ${{ github.ref_name }} -v
         env:
           AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
           AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}

src/sessionStorage.server.test.ts

@@ -16,7 +16,6 @@ describe('The session storage', () => {
   });
 
   it('returns the configured one', async () => {
-    delete process.env.SESSION_SECRET;
     process.env.NODE_ENV = 'development';
     vi.mocked(createCookieSessionStorage).mockReturnValue('mocked cookie' as never);
     const { getSessionStorage } = await import ('~/sessionStorage.server');

src/split.server.test.ts

@@ -17,29 +17,6 @@ describe('The split client', () => {
     vi.resetAllMocks();
   });
 
-  it('set the defaults', async () => {
-    delete process.env.SPLIT_SERVER_TOKEN;
-    process.env.NODE_ENV = 'production';
-    vi.mocked(SplitFactory).mockReturnValue({
-      client: vi.fn().mockReturnValue('client')
-    } as never);
-
-    const client = (await import('./split.server')).default;
-
-    const calls = vi.mocked(SplitFactory).mock.calls;
-
-    expect(client).toEqual('client');
-    expect(calls[0][0]).toMatchInlineSnapshot(`
-      {
-        "core": {
-          "authorizationKey": "localhost",
-        },
-        "debug": false,
-        "features": "/cwd/sub/devFeatures.yml",
-      }
-    `);
-  });
-
   it('set the environments', async () => {
     process.env.SPLIT_SERVER_TOKEN = 'token';
     process.env.NODE_ENV = 'development';

src/split.server.ts

@@ -3,7 +3,7 @@ import { SplitFactory } from '@splitsoftware/splitio/server';
 // eslint-disable-next-line new-cap
 const splitFactory = SplitFactory({
   core: {
-    authorizationKey: process.env.SPLIT_SERVER_TOKEN || 'localhost'
+    authorizationKey: process.env.SPLIT_SERVER_TOKEN
   },
   debug: process.env.SPLIT_DEBUG === 'true',
   features: path.resolve(process.cwd(), '../devFeatures.yml')

types/globals.d.ts

@@ -15,6 +15,19 @@ declare global {
     appConfig: AppConfig;
     locale: strin;
   }
+
+  namespace NodeJS {
+    interface ProcessEnv {
+      COOKIEYES_TOKEN: string;
+      HOTJAR_ID: string;
+      MIXPANEL_API: string;
+      MIXPANEL_TOKEN: string;
+      NODE_ENV: string;
+      SESSION_SECRET: string | undefined
+      SPLIT_SERVER_TOKEN: string;
+      I18N_DEBUG: string;
+    }
+  }
 }
 
 export {};