feat(events): HITL approvals emit the agent event schema - #634
Open
jakedipity wants to merge 3 commits into
Open
feat(events): HITL approvals emit the agent event schema#634jakedipity wants to merge 3 commits into
jakedipity wants to merge 3 commits into
Conversation
Greptile SummaryThe PR migrates five HITL approval lifecycle publication sites to the unified agent-event schema while preserving delivery through the existing approval broker.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| crates/aura/src/hitl/route.rs | Migrates five approval lifecycle publications to the agent-event emitter, whose adapter preserves the existing approval-broker payload and routing behavior. |
Sequence Diagram
sequenceDiagram
participant H as HITL decision route
participant E as agent_events::emit
participant B as Approval event broker
participant S as Web or CLI stream
H->>E: AgentEvent with approval payload
E->>B: ApprovalLifecycleEvent keyed by request ID
B->>S: Requested, pending, or completed event
Reviews (2): Last reviewed commit: "feat(events): HITL approvals emit the ag..." | Re-trigger Greptile
Adds aura_events::agent, the event vocabulary a running agent emits, and aura::agent_events, which republishes it onto the request-scoped brokers so consumers are unaffected. A differential test asserts both paths produce identical SSE. No producer emits the schema yet; agent_events_enabled reads AURA_AGENT_EVENTS and is the seam producers will gate on. Ref: #618 Signed-off-by: Jacob Hull <jacob@planethull.com>
The four single-agent emission sites — the hook's tool_requested and tool_usage, MCP tool_start, and MCP progress — build AgentEvents and go through agent_events::emit, which publishes to the broker each payload belongs to. A differential test drives the same sequence through the broker calls and through emit, asserting the SSE frames match. emit is the seam a real event stream attaches to once a consumer reads it directly. Ref: #620 Signed-off-by: Jacob Hull <jacob@planethull.com>
jakedipity
force-pushed
the
jakedipity/single-agent-event-producer
branch
from
September 3, 2026 19:43
0ad5573 to
89cf3cc
Compare
The five approval publish sites in the decision route build AgentEvents and go through agent_events::emit, alongside the other producers that reach consumers via a broker. Ref: #624 Signed-off-by: Jacob Hull <jacob@planethull.com>
jakedipity
force-pushed
the
jakedipity/hitl-event-schema
branch
from
September 3, 2026 20:09
9ee8dad to
88e586a
Compare
jakedipity
force-pushed
the
jakedipity/single-agent-event-producer
branch
2 times, most recently
from
September 3, 2026 20:42
c0afcc9 to
ac61392
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The five approval publish sites in the decision route build AgentEvents and go through agent_events::emit, alongside the other producers that reach consumers via a broker.
Ref: #624