Skip to content

Added X-Amz-Content-Sha256 for aoss. #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dblock wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added X-Amz-Content-Sha256 for aoss. #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aws4.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ RequestSigner.prototype.prepareRequest = function() {
if (this.credentials.sessionToken && !headers['X-Amz-Security-Token'] && !headers['x-amz-security-token'])
headers['X-Amz-Security-Token'] = this.credentials.sessionToken

if (this.service === 's3' && !headers['X-Amz-Content-Sha256'] && !headers['x-amz-content-sha256'])
if ((this.service === 's3' || this.service === 'aoss') && !headers['X-Amz-Content-Sha256'] && !headers['x-amz-content-sha256'])
headers['X-Amz-Content-Sha256'] = hash(this.request.body || '', 'hex')

if (headers['X-Amz-Date'] || headers['x-amz-date'])
Expand Down
32 changes: 32 additions & 0 deletions test/fast.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,38 @@ describe('aws4', function() {
})
})

describe('#sign() without X-Amz-Content-Sha256 header', function() {
it('should not add header for any service', function() {
var opts = aws4.sign({
service: 'aos',
method: 'PUT',
path: '/some-bucket/file.txt',
body: 'Test Body'
})
opts.headers.should.not.have.property('X-Amz-Content-Sha256')
})

it('should add header for s3', function() {
var opts = aws4.sign({
service: 's3',
method: 'PUT',
path: '/some-bucket/file.txt',
body: 'Test Body'
})
opts.headers['X-Amz-Content-Sha256'].should.equal('ae6d8a1c07f438667618879eae74ffab84c236ea5d8ca52d5ca0523cc35e8bb9')
})

it('should add header for an empty body for aoss', function() {
var opts = aws4.sign({
service: 'aoss',
method: 'PUT',
path: '/some-bucket/file.txt',
body: undefined
})
opts.headers['X-Amz-Content-Sha256'].should.equal('e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855')
})
})

describe('#sign() with extraHeadersToIgnore', function() {
it('should generate signature correctly', function() {
var opts = aws4.sign({
Expand Down