Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set generator: support adding imports to generated set #2

Open
mhuxtable opened this issue Apr 13, 2020 · 0 comments
Open

set generator: support adding imports to generated set #2

mhuxtable opened this issue Apr 13, 2020 · 0 comments

Comments

@mhuxtable
Copy link
Owner

The set generator cannot emit sets for datatypes which are not primitive types, as there is no way to add the relevant import path. Add this option to the set generator.

mhuxtable added a commit that referenced this issue Apr 13, 2020
This introduces a generator for sets of arbitrary Go data types and converts
the top-level generic set to be generated in this way. There are a large number
of build system changes to support the large amount of generated code. The
generated sets are currently intended to have no dependencies on the top-level
module of this package, and have only one external dependency to a well-known
test assert library (github.com/stretchr/testify).

We use multiple Go modules to separate the imports required for the generator
from the imports necessary to use the canned generated set genericset
package.

Special care is taken to continue to support the v1 API of the genericset in
the top-level package.

This doesn't support non-primitive types until #2 is completed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant