Bug fixes and test improvements

Author: michaelkourlas

CHANGES.md

@@ -1,3 +1,7 @@
+## 2.0.2 ##
+
+* Bug fixes
+
 ## 2.0.1 ##
 
 * Remove unnecessary development dependencies from npm shrinkwrap

README.md

@@ -67,7 +67,7 @@ includes source maps.
 
 ## Usage ##
 
-The documentation for the current version is available [here](http://www.kourlas.com/node-js2xmlparser/docs/2.0.1/).
+The documentation for the current version is available [here](http://www.kourlas.com/node-js2xmlparser/docs/2.0.2/).
 
 You can also build the documentation using gulp:
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "js2xmlparser",
-  "version": "2.0.1",
+  "version": "2.0.2",
   "description": "Parses JavaScript objects into XML",
   "keywords": [
     "convert",

src/main.ts

@@ -71,11 +71,16 @@ function parseAttribute(name: string, value: string, parentElement: XmlElement,
                         options: IOptions): void
 {
     let attribute = parentElement.attribute(name, "");
-    if (!isType(value, "String")) {
-        throw new Error("attribute value for name '" + name + "' should be a" +
-                        " string");
+    if (isType(value, "String") || isType(value, "Number")
+        || isType(value, "Boolean") || isType(value, "Undefined")
+        || isType(value, "Null"))
+    {
+        parseString(stringify(value), attribute, options);
+    } else {
+        throw new Error("attribute value for name '" + name + "' should be a"
+                        + " primitive (string, number, boolean, null, or"
+                        + " undefined)");
     }
-    parseString(value, attribute, options);
 }
 
 /**
@@ -127,8 +132,8 @@ function parseObjectOrMapEntry(key: string, value: any,
             parseValue(key, value, parentElement, options);
             return;
         } else {
-            throw new Error("value value " + value + " must be a primitive"
-                            + " (string, number, null, or undefined)");
+            throw new Error("value " + value + " should be a primitive"
+                            + " (string, number, boolean, null, or undefined)");
         }
     }
 

src/options.ts

@@ -53,7 +53,7 @@ export interface IOptions {
      * object.
      *
      * The attribute object must be an object containing keys that map to
-     * strings.
+     * primitives (string, number, boolean, null, or undefined).
      *
      * For example, if `attributeString` is `"@"`, then the following object:
      * ```javascript

test/src/main.ts

@@ -483,12 +483,17 @@ describe("parser", () => {
                             {
                                 "@": {
                                     "test1": "test2",
-                                    "test3": "test4"
+                                    "test3": "test4",
+                                    "test5": 3,
+                                    "test6": null,
+                                    "test7": undefined,
+                                    "test8": true
                                 }
                             },
                             simpleOptions
                         ),
-                        "<root test1='test2' test3='test4'/>"
+                        "<root test1='test2' test3='test4' test5='3' "
+                        + "test6='null' test7='undefined' test8='true'/>"
                     );
 
                     assert.strictEqual(
@@ -543,7 +548,7 @@ describe("parser", () => {
                             "root",
                             {
                                 "@": {
-                                    "test": 3
+                                    "test": {}
                                 }
                             },
                             simpleOptions
@@ -846,13 +851,27 @@ describe("parser", () => {
                                     <[string, string]> ["test8", "test9"],
                                     <[string, string]> ["#", "test10"],
                                     <[string, string]> ["test11", "test12"]
-                                ])
+                                ]),
+                                "test13": {
+                                    "#": 3
+                                },
+                                "test14": {
+                                    "#": true
+                                },
+                                "test15": {
+                                    "#": null
+                                },
+                                "test16": {
+                                    "#": undefined
+                                }
                             },
                             simpleOptions
                         ),
                         "<root><test1><test2>test3</test2>test6<test4>test5"
                         + "</test4></test1><test7><test8>test9</test8>test10"
-                        + "<test11>test12</test11></test7></root>"
+                        + "<test11>test12</test11></test7><test13>3</test13>"
+                        + "<test14>true</test14><test15>null</test15><test16>"
+                        + "undefined</test16></root>"
                     );
 
                     assert.strictEqual(