Skip to content

In the TCK parameters to Assert.assertEquals are reversed in some cases #221

@tjquinno

Description

@tjquinno

Describe the bug

At least some code in the TCKs reverses the expected and actual parameters in the Assert.assertEquals method invocations.

One example:

https://github.com/eclipse/microprofile-telemetry/blob/5ab478e8f3cb26f995bb48877855d8934c7eb8ed/tck/tracing/src/main/java/org/eclipse/microprofile/telemetry/tracing/tck/rest/W3BaggagePropagationTest.java#L110-L111

The first parameter should be the actual value and the second the expected value

https://javadoc.io/static/org.testng/testng/7.10.2/org/testng/asserts/Assertion.html#assertEquals(boolean,boolean)

public static void assertEquals(int actual, int expected )

but they are reversed here (and possibly elsewhere).

If the implementation works correctly then the assertion passes anyway, so this is not a big problem but should be addressed eventually.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions