micropython/mip: Allow relative URLs in package.json files.#975
Merged
dpgeorge merged 1 commit intomicropython:masterfrom Feb 24, 2025
Merged
micropython/mip: Allow relative URLs in package.json files.#975dpgeorge merged 1 commit intomicropython:masterfrom
dpgeorge merged 1 commit intomicropython:masterfrom
Conversation
glenn20
changed the title
Contributor
Author
|
Basic functionality can be tested with: |
dpgeorge
approved these changes
Feb 24, 2025
Member
dpgeorge
left a comment
dpgeorge
left a comment
There was a problem hiding this comment.
Thank you!
I tested it with a test package hosted at https://dpgeorge.net/resources/mip_test and it works well.
This allows to specify relative URLs in package.json, which are resolved relative to the package.json URL. This mirrors the functionality added to mpremote in micropython/micropython#12477. Signed-off-by: Glenn Moloney <glenn.moloney@gmail.com>
dpgeorge
force-pushed
the
feature-mip-relative-url
branch
from
35aa54e to
b379e4f
Compare
Member
|
Side note: I think we should add support in MicroPython core to pass a tuple of strings to |
Contributor
Author
@dpgeorge I've just pushed #16812 to provide that (and also support for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows URLs in package.json files to be specified relative to the directory containing the
package.jsonfile. This mirrors the functionality added to mpremote in micropython:#12477.This simplifies use of mip packages from forked or copied repos.
Example package.json: