Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow enablement of Trusted Launch and vTPM for VMs #4265

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jonnyry
Copy link
Collaborator

@jonnyry jonnyry commented Jan 9, 2025

Resolves #4235

What is being addressed

Provide Secure Boot and vTPM options to VMs running in the TRE.

Since enabling Secure Boot and vTPM in terraform is a destructive action, we need to be careful about how this is enabled and make use of ignore_changes to prevent certain machines being recreated.


1. Guacamole VMs

Surface the Secure Boot and vTPM VM options in porter.yaml, to allow easier setting of these, and on a per image basis since not all images support these options.

e.g.

  image_options:
    "Windows 10":
      source_image_reference:
        publisher: MicrosoftWindowsDesktop
        offer: Windows-10
        sku: win10-22h2-pro-g2
        version: latest
      conda_config: false
      secure_boot_enabled: true
      vtpm_enabled: true

lifecycle { ignore_changes = [secure_boot_enabled, vtpm_enabled] } is set to prevent recreation of existing machines.

Guacamole images enabled for secure boot

The following images within Guacamole templates have secure_boot_enabled: true and vtpm_enabled: true:

  • windows10 / win10-22h2-pro-g2
  • windows 11 / win11-24h2-pro
  • Ubuntu 22_04-lts-gen2

Guacamole images NOT enabled for secure boot

The following images within Guacamole templates have secure_boot_enabled: false and vtpm_enabled: false because the image is not a gen2 image:

  • winserver 2019 / dsvm-win-2019

2. Other VMs

a) Resource Processor

Enable both options, and allow recreation of scale set.

b) Admin VM

Enable both options, but set lifecycle { ignore_changes = [secure_boot_enabled, vtpm_enabled] } to prevent recreation of existing machines.

c) Sonotype Nexus VM

Enable both options, but set lifecycle { ignore_changes = [secure_boot_enabled, vtpm_enabled] } to prevent recreation of existing machines.

@jonnyry jonnyry requested review from marrobi and tamirkamara January 9, 2025 12:29
Copy link

github-actions bot commented Jan 9, 2025

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 5face13.

♻️ This comment has been updated with latest results.

@jonnyry
Copy link
Collaborator Author

jonnyry commented Jan 9, 2025

/test d06eb51

Copy link

github-actions bot commented Jan 9, 2025

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12690003969 (with refid ba99c041)

(in response to this comment from @jonnyry)

@jonnyry
Copy link
Collaborator Author

jonnyry commented Jan 9, 2025

/test d06eb51

Copy link

github-actions bot commented Jan 9, 2025

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12690096829 (with refid ba99c041)

(in response to this comment from @jonnyry)

@jonnyry
Copy link
Collaborator Author

jonnyry commented Jan 9, 2025

/test d06eb51

Copy link

github-actions bot commented Jan 9, 2025

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12691203106 (with refid ba99c041)

(in response to this comment from @jonnyry)

@jonnyry jonnyry changed the title Allow enablement of Trusted Launch and vTPM for Guacamole VMs Allow enablement of Trusted Launch and vTPM for VMs Jan 9, 2025
@jonnyry
Copy link
Collaborator Author

jonnyry commented Jan 9, 2025

/test fcd59f8

Copy link

github-actions bot commented Jan 9, 2025

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12699973353 (with refid ba99c041)

(in response to this comment from @jonnyry)

@jonnyry
Copy link
Collaborator Author

jonnyry commented Jan 10, 2025

/test 8b53ffa

Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12700734035 (with refid ba99c041)

(in response to this comment from @jonnyry)

@jonnyry
Copy link
Collaborator Author

jonnyry commented Jan 11, 2025

/test destroy-env

Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12727130752 (with refid ba99c041)

(in response to this comment from @jonnyry)

@jonnyry
Copy link
Collaborator Author

jonnyry commented Jan 11, 2025

/test-destroy-env

Copy link

Destroying PR test environment (RG: rg-treba99c041)... (run: https://github.com/microsoft/AzureTRE/actions/runs/12727177492)

Copy link

PR test environment destroy complete (RG: rg-treba99c041)

@jonnyry
Copy link
Collaborator Author

jonnyry commented Jan 11, 2025

/test 99f0c52

Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12727357688 (with refid ba99c041)

(in response to this comment from @jonnyry)

@jonnyry
Copy link
Collaborator Author

jonnyry commented Jan 11, 2025

/test 99f0c52

Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12727394266 (with refid ba99c041)

(in response to this comment from @jonnyry)

@jonnyry jonnyry requested a review from yuvalyaron January 12, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow enablement of Trusted Launch and vTPM for VMs
1 participant