-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow enablement of Trusted Launch and vTPM for VMs #4265
base: main
Are you sure you want to change the base?
Conversation
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 5face13. ♻️ This comment has been updated with latest results. |
/test d06eb51 |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12690003969 (with refid (in response to this comment from @jonnyry) |
/test d06eb51 |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12690096829 (with refid (in response to this comment from @jonnyry) |
/test d06eb51 |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12691203106 (with refid (in response to this comment from @jonnyry) |
/test fcd59f8 |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12699973353 (with refid (in response to this comment from @jonnyry) |
/test 8b53ffa |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12700734035 (with refid (in response to this comment from @jonnyry) |
/test destroy-env |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12727130752 (with refid (in response to this comment from @jonnyry) |
/test-destroy-env |
Destroying PR test environment (RG: rg-treba99c041)... (run: https://github.com/microsoft/AzureTRE/actions/runs/12727177492) |
PR test environment destroy complete (RG: rg-treba99c041) |
/test 99f0c52 |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12727357688 (with refid (in response to this comment from @jonnyry) |
/test 99f0c52 |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12727394266 (with refid (in response to this comment from @jonnyry) |
Resolves #4235
What is being addressed
Provide Secure Boot and vTPM options to VMs running in the TRE.
Since enabling Secure Boot and vTPM in terraform is a destructive action, we need to be careful about how this is enabled and make use of
ignore_changes
to prevent certain machines being recreated.1. Guacamole VMs
Surface the Secure Boot and vTPM VM options in porter.yaml, to allow easier setting of these, and on a per image basis since not all images support these options.
e.g.
lifecycle { ignore_changes = [secure_boot_enabled, vtpm_enabled] }
is set to prevent recreation of existing machines.Guacamole images enabled for secure boot
The following images within Guacamole templates have
secure_boot_enabled: true
andvtpm_enabled: true
:Guacamole images NOT enabled for secure boot
The following images within Guacamole templates have
secure_boot_enabled: false
andvtpm_enabled: false
because the image is not a gen2 image:2. Other VMs
a) Resource Processor
Enable both options, and allow recreation of scale set.
b) Admin VM
Enable both options, but set
lifecycle { ignore_changes = [secure_boot_enabled, vtpm_enabled] }
to prevent recreation of existing machines.c) Sonotype Nexus VM
Enable both options, but set
lifecycle { ignore_changes = [secure_boot_enabled, vtpm_enabled] }
to prevent recreation of existing machines.