Add validation to Template API endpoints

[marrobi]

Fixes #1123

Add validation to API endpoints to ensure correct resourceType in template registration payloads.

• Workspace Service Templates: Add validation in api_app/api/routes/workspace_service_templates.py to check if resourceType is WorkspaceService before registering the template. Return a 422 Unprocessable Entity error if the resourceType does not match.
• Workspace Templates: Add validation in api_app/api/routes/workspace_templates.py to check if resourceType is Workspace before registering the template. Return a 422 Unprocessable Entity error if the resourceType does not match.
• User Resource Templates: Add validation in api_app/api/routes/user_resource_templates.py to check if resourceType is UserResource before registering the template. Return a 422 Unprocessable Entity error if the resourceType does not match.
• Shared Service Templates: Add validation in api_app/api/routes/shared_service_templates.py to check if resourceType is SharedService before registering the template. Return a 422 Unprocessable Entity error if the resourceType does not match.
• Common Error Message: Add a common error message string INVALID_RESOURCE_TYPE in api_app/resources/strings.py for validation errors, including the expected and received resourceType.
• Tests: Add tests in api_app/tests_ma/test_api/test_routes/test_workspace_service_templates.py, api_app/tests_ma/test_api/test_routes/test_workspace_templates.py, api_app/tests_ma/test_api/test_routes/test_user_resource_templates.py, and api_app/tests_ma/test_api/test_routes/test_shared_service_templates.py to cover validation for each template registration

---

For more details, open the Copilot Workspace session.

[github-actions]

Unit Test Results

612 tests   612 ✅  7s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit b72ca14.

♻️ This comment has been updated with latest results.

[marrobi]

This PR uncovered a few test bugs, however we are inconsistent with our resourceType naming. In the CI and makefile we use workspace_service, in the Python API we use workspace-service`.

Going to leave this here, but should resolve this inconsistency. Suggest by amending the CI and makefile to use -.

vs

[marrobi]

Propose we should handle the naming difference in the Python code, and deal with the script update later, add notes to the release, then revert the Python in the future.

[martinpeck]

Marking as ready for review.
Can't be merged as-is.

[martinpeck]

I've left a question/comment but LGTM either way.

[marrobi]

Propose we should handle the naming difference in the Python code, and deal with the script update later, add notes to the release, then revert the Python in the future.

@martinpeck what think of best way to sort this? The scripts send resources with _ vs expecting - , see /workspaces/marrobi-azuretre/.github/workflows/deploy_tre_reusable.yml for for example.

I don't want to break everyone's pipelines.

Could do a replace of _ for - here: https://github.com/marrobi/AzureTRE/blob/973a02d7691a1e9272197d9159bb1699ec0a8e4a/devops/scripts/register_bundle_with_api.sh#L102-L103

[martinpeck]

@marrobi honestly, I'm a bit confused about the underscore/hyphen issue. Perhaps let's chat.

[martinpeck]

If we did patch up the problem in that script, I would suggest we do that only as a temp measure, generate a warning saying "WARNING: Fix this cos we won't patch this for you later", and then remove that patch code in a later release.