Skip to content

Conversation

@JC-wk
Copy link
Collaborator

@JC-wk JC-wk commented Nov 4, 2025

Resolves #4727

Draft PR

This is in draft because

  • unit testing may be needed
  • I have noted an edge case of the address being released during a failed uninstall and then allocated elsewhere. I need to move the deallocation process to run after the main step has succeeded so it runs after the terraform uninstall. I am testing doing this in the service_bus now and it is working ok.
  • To allow other to try this out and comment on it

What is being addressed

Currently address spaces are not cleaned up when a workspace service is uninstalled from a workspace, this could lead to ip range exhaustion.
This PR adds the functionality to delete the address_space used by a workspace-service on uninstall of the service. The address range is then freed from the workspace and can be reused.

How is this addressed

  • Adds a step to the api to delete the address space when a workspace service is uninstalled
  • Updates templates to conduct a workspace upgrade after uninstall
  • I have not added any tests but happy to accept advice on how to implement these
  • Updated documentation
  • Updated CHANGELOG.md
  • Increment template versions

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

Unit Test Results

658 tests   658 ✅  7s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit f38ef4a.

♻️ This comment has been updated with latest results.

@JC-wk JC-wk marked this pull request as ready for review November 10, 2025 09:50
@JC-wk JC-wk requested a review from a team as a code owner November 10, 2025 09:50
@JC-wk
Copy link
Collaborator Author

JC-wk commented Nov 10, 2025

I have been testing this for a few days, I am not sure if unit tests are needed and how best to write them if anyone wants to assist.

@JC-wk JC-wk marked this pull request as draft November 10, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IP address spaces are not deallocated when a workspace service is uninstalled

1 participant