Remove now-unused code specific to a deprecated platform (#6781)

Author: achamayou

include/ccf/pal/attestation.h

@@ -13,12 +13,7 @@
 
 #include <fcntl.h>
 #include <functional>
-
-#if !defined(INSIDE_ENCLAVE) || defined(VIRTUAL_ENCLAVE)
-#  include <sys/ioctl.h>
-#else
-#  include "ccf/pal/attestation_sgx.h"
-#endif
+#include <sys/ioctl.h>
 
 namespace ccf::pal
 {

include/ccf/pal/attestation_sgx.h

@@ -15,13 +15,4 @@ namespace ccf::pal
    * Virtual enclaves and the host code share the same PAL.
    */
   using Mutex = std::mutex;
-
-#if !defined(INSIDE_ENCLAVE) || defined(VIRTUAL_ENCLAVE)
-  static inline void speculation_barrier() {}
-#else
-  static inline void speculation_barrier()
-  {
-    oe_lfence();
-  }
-#endif
 }

include/ccf/pal/locking.h

@@ -164,8 +164,6 @@ extern "C"
 
       ccf::enclavetime::host_time_us =
         static_cast<decltype(ccf::enclavetime::host_time_us)>(time_location);
-
-      ccf::pal::speculation_barrier();
     }
 
     if (!ccf::pal::is_outside_enclave(ccf_config, ccf_config_size))
@@ -181,8 +179,6 @@ extern "C"
       return CreateNodeStatus::MemoryNotOutsideEnclave;
     }
 
-    ccf::pal::speculation_barrier();
-
     ccf::StartupConfig cc =
       nlohmann::json::parse(ccf_config, ccf_config + ccf_config_size);
 

src/enclave/main.cpp

@@ -16,10 +16,6 @@
 #include <cstdarg>
 #include <quickjs/quickjs.h>
 
-#if defined(INSIDE_ENCLAVE) && !defined(VIRTUAL_ENCLAVE)
-#  include <openenclave/3rdparty/libc/sys/time.h> // For timeval
-#endif
-
 namespace ccf::js::core
 {
   namespace

src/js/core/context.cpp

@@ -317,8 +317,6 @@ namespace ccf
         return false;
       }
 
-      ccf::pal::speculation_barrier();
-
       std::copy(
         pending_snapshot.serialised_snapshot.begin(),
         pending_snapshot.serialised_snapshot.end(),