Skip to content

Commit 917b8f5

Browse files
sethsteenkensethsteenken
andauthored
Fix/deploy registry codespaces (#16)
* Infra - default acr * Devcontainer - init * Dev container - az cli * Devcontainer - random * Devcontainer - more random * Devcontainer - remove extensions * Devcontainer - added back extensions to test --------- Co-authored-by: sethsteenken <sethsteenken@microsoft.com>
1 parent 4a837d3 commit 917b8f5

File tree

2 files changed

+40
-2
lines changed

2 files changed

+40
-2
lines changed

.devcontainer/devcontainer.json

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
{
2+
"name": "DevContainer for Container Migration Solution Accelerator",
3+
"image": "mcr.microsoft.com/devcontainers/python:3.12-bullseye",
4+
"features": {
5+
"ghcr.io/dhoeric/features/hadolint:1": {},
6+
"ghcr.io/jsburckhardt/devcontainer-features/uv:1": {},
7+
"ghcr.io/devcontainers/features/azure-cli:1": {},
8+
"ghcr.io/azure/azure-dev/azd:latest": {}
9+
},
10+
"customizations": {
11+
"vscode": {
12+
"extensions": [
13+
"charliermarsh.ruff",
14+
"exiasr.hadolint",
15+
"kevinrose.vsc-python-indent",
16+
"mosapride.zenkaku",
17+
"ms-azuretools.vscode-docker",
18+
"ms-python.python",
19+
"njpwerner.autodocstring",
20+
"redhat.vscode-yaml",
21+
"shardulm94.trailing-spaces",
22+
"tamasfe.even-better-toml",
23+
"yzhang.markdown-all-in-one",
24+
"ms-vscode.azure-account",
25+
"ms-azuretools.azure-dev",
26+
"tonybaloney.vscode-pets",
27+
"humao.rest-client"
28+
]
29+
}
30+
},
31+
"containerEnv": {
32+
"DISPLAY": "dummy",
33+
"PYTHONUNBUFFERED": "True",
34+
"UV_LINK_MODE": "copy",
35+
"UV_PROJECT_ENVIRONMENT": ".venv"
36+
},
37+
"remoteUser": "vscode"
38+
}

infra/main.bicep

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ param location string = resourceGroup().location
3838
@description('Optional. Location for all AI service resources. This location can be different from the resource group location.')
3939
param aiDeploymentLocation string?
4040

41-
@description('Required. The host (excluding https://) of an existing container registry. This is the `loginServer` when using Azure Container Registry.')
42-
param containerRegistryHost string
41+
@description('Optional. The host (excluding https://) of an existing container registry. This is the `loginServer` when using Azure Container Registry.')
42+
param containerRegistryHost string = 'containermigrationacr.azurecr.io'
4343

4444
@minLength(1)
4545
@allowed(['Standard', 'GlobalStandard'])

0 commit comments

Comments
 (0)