Skip to content

Commit dafd00b

Browse files
sethsteenkensethsteenken
andauthored
Azd/pass validation (#21)
* AZD - updates to pass validation * AZD - infra - cosmos disableLocalAuth --------- Co-authored-by: sethsteenken <sethsteenken@microsoft.com>
1 parent d776028 commit dafd00b

File tree

9 files changed

+147
-3
lines changed

9 files changed

+147
-3
lines changed
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
<!--
2+
IF SUFFICIENT INFORMATION IS NOT PROVIDED VIA THE FOLLOWING TEMPLATE THE ISSUE MIGHT BE CLOSED WITHOUT FURTHER CONSIDERATION OR INVESTIGATION
3+
-->
4+
> Please provide us with the following information:
5+
> ---------------------------------------------------------------
6+
7+
### This issue is for a: (mark with an `x`)
8+
```
9+
- [ ] bug report -> please search issues before submitting
10+
- [ ] feature request
11+
- [ ] documentation issue or request
12+
- [ ] regression (a behavior that used to work and stopped in a new release)
13+
```
14+
15+
### Minimal steps to reproduce
16+
>
17+
18+
### Any log messages given by the failure
19+
>
20+
21+
### Expected/desired behavior
22+
>
23+
24+
### OS and Version?
25+
> Windows 7, 8 or 10. Linux (which distribution). macOS (Yosemite? El Capitan? Sierra?)
26+
27+
### azd version?
28+
> run `azd version` and copy paste here.
29+
30+
### Versions
31+
>
32+
33+
### Mention any other details that might be useful
34+
35+
> ---------------------------------------------------------------
36+
> Thanks! We'll be in touch soon.
Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
1+
---
2+
name: Bug report
3+
about: Create a report to help us improve
4+
title: ''
5+
labels: bug
6+
assignees: ''
7+
8+
---
9+
10+
# Describe the bug
11+
A clear and concise description of what the bug is.
12+
13+
# Expected behavior
14+
A clear and concise description of what you expected to happen.
15+
16+
# How does this bug make you feel?
17+
_Share a gif from [giphy](https://giphy.com/) to tells us how you'd feel_
18+
19+
---
20+
21+
# Debugging information
22+
23+
## Steps to reproduce
24+
Steps to reproduce the behavior:
25+
1. Go to '...'
26+
2. Click on '....'
27+
3. Scroll down to '....'
28+
4. See error
29+
30+
## Screenshots
31+
If applicable, add screenshots to help explain your problem.
32+
33+
## Logs
34+
35+
If applicable, add logs to help the engineer debug the problem.
36+
37+
---
38+
39+
# Tasks
40+
41+
_To be filled in by the engineer picking up the issue_
42+
43+
- [ ] Task 1
44+
- [ ] Task 2
45+
- [ ] ...
Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
---
2+
name: Feature request
3+
about: Suggest an idea for this project
4+
title: ''
5+
labels: enhancement
6+
assignees: ''
7+
8+
---
9+
10+
# Motivation
11+
12+
A clear and concise description of why this feature would be useful and the value it would bring.
13+
Explain any alternatives considered and why they are not sufficient.
14+
15+
# How would you feel if this feature request was implemented?
16+
17+
_Share a gif from [giphy](https://giphy.com/) to tells us how you'd feel. Format: ![alt_text](https://media.giphy.com/media/xxx/giphy.gif)_
18+
19+
# Requirements
20+
21+
A list of requirements to consider this feature delivered
22+
- Requirement 1
23+
- Requirement 2
24+
- ...
25+
26+
# Tasks
27+
28+
_To be filled in by the engineer picking up the issue_
29+
30+
- [ ] Task 1
31+
- [ ] Task 2
32+
- [ ] ...

.github/ISSUE_TEMPLATE/subtask.md

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
---
2+
name: Sub task
3+
about: A sub task
4+
title: ''
5+
labels: subtask
6+
assignees: ''
7+
8+
---
9+
10+
Required by <link to parent issue>
11+
12+
# Description
13+
14+
A clear and concise description of what this subtask is.
15+
16+
# Tasks
17+
18+
_To be filled in by the engineer picking up the subtask
19+
20+
- [ ] Task 1
21+
- [ ] Task 2
22+
- [ ] ...
File renamed without changes.

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -416,3 +416,4 @@ FodyWeavers.xsd
416416
*.msix
417417
*.msm
418418
*.msp
419+
.azure

README.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ The solution uses a sophisticated multi-agent orchestration pattern where specia
2424
4. **YAML Conversion**: Expert YAML transformation with security, networking, and storage optimizations
2525
5. **Documentation Generation**: Comprehensive migration reports with expert insights
2626

27-
### Key features
27+
## Features
2828

2929
This solution enables enterprise-grade Kubernetes migration with the following capabilities:
3030

@@ -66,6 +66,8 @@ If you want to get know more detail about Agentic Architecture, please take a lo
6666
- **Microsoft MCP Server**: Document search and knowledge retrieval
6767
- **Intelligent Tool Selection**: Agents autonomously choose appropriate tools based on context
6868

69+
## Resources
70+
6971
### How to customize
7072

7173
If you'd like to customize the solution accelerator, here are some common areas to start:
@@ -88,6 +90,8 @@ If you'd like to customize the solution accelerator, here are some common areas
8890

8991
[MCP Server Integration Guide](docs/MCPServerGuide.md)
9092

93+
## Getting Started
94+
9195
## <img src="docs/images/readme/quick-deploy.png" width="48" alt="Quick deploy" />[Quick deploy](#quick-deploy)
9296

9397
### How to install or deploy
@@ -130,6 +134,8 @@ Use the [Azure pricing calculator](https://azure.microsoft.com/pricing/calculato
130134
- **Registration Requirements**: Some models may require registration for access
131135
- **Quota Management**: Ensure sufficient TPM (tokens per minute) quota for batch processing
132136

137+
## Guidance
138+
133139
## <img src="docs/images/readme/business_scenario.png" width="48">[Migration Scenario](#migration-scenario)
134140

135141
A DevOps engineer at a multi-cloud enterprise manages Kubernetes workloads across GKE, EKS, and needs to migrate critical applications to Azure Kubernetes Service (AKS) following company cloud consolidation strategy.
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
1+
# yaml-language-server: $schema=https://raw.githubusercontent.com/Azure/azure-dev/main/schemas/v1.0/azure.yaml.json
2+
13
name: container-migration-solution-accelerator
24
metadata:
35
template: container-migration-solution-accelerator@1.0
46

57
requiredVersions:
6-
azd: '>=1.18.2'
8+
azd: '>=1.18.2'

infra/modules/cosmosDb.bicep

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ module cosmosAccount 'br/public:avm/res/document-db/database-account:0.15.1' = {
7979
backupPolicyType: !empty(secondaryLocation) ? 'Periodic' : 'Continuous'
8080
backupStorageRedundancy: zoneRedundant ? 'Zone' : 'Local'
8181
disableKeyBasedMetadataWriteAccess: false
82-
disableLocalAuthentication: privateNetworkingEnabled
82+
disableLocalAuthentication: true
8383
diagnosticSettings: !empty(logAnalyticsWorkspaceResourceId)? [{ workspaceResourceId: logAnalyticsWorkspaceResourceId }]: []
8484
privateEndpoints: privateNetworkingEnabled
8585
? [

0 commit comments

Comments
 (0)