Add ERROR_DEV_NOT_EXIST handling on volume enumeration (#49)

stan-sz · web-flow · commit 945d3160e764 · 2024-09-24T09:34:20.000-07:00
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -26,7 +26,7 @@
   <PropertyGroup>
 
     <!-- DOCSYNC: When changing version number update README.md -->
-    <Version>0.3.10.0</Version>
+    <Version>0.3.11.0</Version>
     <AssemblyVersion>0.9.9999.0</AssemblyVersion>
 
     <Company>Microsoft</Company>
diff --git a/README.md b/README.md
@@ -43,6 +43,7 @@ File clones on Windows do not actually allocate space on-drive for the clone. Th
 
 [![NuGet version (CopyOnWrite)](https://img.shields.io/nuget/v/CopyOnWrite?style=plastic)](https://www.nuget.org/packages/CopyOnWrite)
 
+* 0.3.11 September 2024: Add ERROR_DEV_NOT_EXIST handling on volume enumeration
 * 0.3.10 September 2024: Add ERROR_NO_SUCH_DEVICE handling on volume enumeration
 * 0.3.9 September 2024: Fix https://github.com/microsoft/CopyOnWrite/issues/44 - follow up on ignoring FILE_NOT_FOUND on volume enumeration
 * 0.3.8 March 2024: Fix https://github.com/microsoft/MSBuildSdks/issues/546 - ignore FILE_NOT_FOUND on volume enumeration. Plus add SourceLink to the main library.
diff --git a/lib/Windows/NativeMethods.cs b/lib/Windows/NativeMethods.cs
@@ -157,6 +157,7 @@ public enum FileSystemFeature : uint
     public const int ERROR_ACCESS_DENIED = 5;
     public const int ERROR_INVALID_HANDLE = 6;
     public const int ERROR_NO_MORE_FILES = 18;
+    public const int ERROR_DEV_NOT_EXIST = 55;
     public const int ERROR_MORE_DATA = 234;
     public const int ERROR_NO_SUCH_DEVICE = 433;
 
diff --git a/lib/Windows/VolumeEnumerator.cs b/lib/Windows/VolumeEnumerator.cs
@@ -144,6 +144,7 @@ private static IReadOnlyList<string> GetVolumePathNamesForVolumeName(
             {
                 int lastErr = Marshal.GetLastWin32Error();
                 if (lastErr == NativeMethods.ERROR_FILE_NOT_FOUND ||
+                    lastErr == NativeMethods.ERROR_DEV_NOT_EXIST ||
                     lastErr == NativeMethods.ERROR_NO_SUCH_DEVICE)
                 {
                     // No mount points for this volume.

Original file line number	Diff line number	Diff line change
`@@ -144,6 +144,7 @@ private static IReadOnlyList<string> GetVolumePathNamesForVolumeName(`
`144`	`144`	`{`
`145`	`145`	`int lastErr = Marshal.GetLastWin32Error();`
`146`	`146`	`if (lastErr == NativeMethods.ERROR_FILE_NOT_FOUND \|\|`
	`147`	`+ lastErr == NativeMethods.ERROR_DEV_NOT_EXIST \|\|`
`147`	`148`	`lastErr == NativeMethods.ERROR_NO_SUCH_DEVICE)`
`148`	`149`	`{`
`149`	`150`	`// No mount points for this volume.`