-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Settings] Modules are incorrectly sorted in the English version #31089
Comments
Would try to work on this! |
Hi @sanidhyas3s that sounds great! Changing the order of these two items is easy. If you think of tackling the order of all the menu items, what would be your plan to solve this? I think it's more complicated than it seems, because some modules are translated and some ar not. |
@Jay-o-Way To sort based on the module names in the language being used. Can there be an issue in that? |
Ok, would first need to finish setting up PowerToys in Visual Studio, then would try solving it. Any help to speed things up would be nice! |
@sanidhyas3s Nice. The project is big and there's a big list to be done to prepare. Looking at your profile, I assume you know the basics. https://github.com/microsoft/PowerToys/blob/main/doc%2Fdevdocs%2Freadme.md will help you on your way. The navigation is in src/settings-ui/Settings.UI/SettingsXAML/Views/ShellPage.xaml |
@Jay-o-Way Not sure if this is the right place to ask, but after having set-up PowerToys/Visual Studio, after making some test changes to the code and building PowerToys (or just the settings) from the |
|
@Jay-o-Way The repo is updated, just my online fork isn't, that is not the issue anyways. What I meant by test changes was just random changes like changing the order of items manually in This is exactly what I am doing:
Also alternatively building using Can you please help me here, new to Visual Studio and using solutions to compile applications. |
This comment was marked as outdated.
This comment was marked as outdated.
Does the compilation succeed? You can also build just the settings projects and see if that helps. |
@Aaron-Junker
Again, sorry for filling up the issue discussion with my doubts. |
The Navigation Pane items are now sorted alphabetically based on their Display Names. Fixes microsoft#31089, microsoft#23763
I have solved this (can verify, atleast for English). I would like to test if this works for other languages, though I am not sure how can I do that, if I change my system language preferences, the actual PowerToys (the one I installed normally) does change its display language, but not the one I am building and running. |
The Navigation Pane items are now sorted alphabetically based on their Display Names. Fixes microsoft#31089, microsoft#23763
A common helper function is made which sorts the items for both the shell pages. Fixes microsoft#31089, microsoft#23763
Hi all, sorry but this is intentionally by design. |
Microsoft PowerToys version
0.77.0
Installation method
GitHub, PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
Settings
Steps to reproduce
Look at the left pane. It is not correctly sorted.
✔️ Expected Behavior
Color Picker should be before Command Not Found.
❌ Actual Behavior
No response
Other Software
No response
The text was updated successfully, but these errors were encountered: