Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Settings] Modules are incorrectly sorted in the English version #31089

Closed
PesBandi opened this issue Jan 22, 2024 · 14 comments
Closed

[Settings] Modules are incorrectly sorted in the English version #31089

PesBandi opened this issue Jan 22, 2024 · 14 comments
Assignees
Labels
Cost-Small Small work item - 0-8 hours of work Issue-Bug Something isn't working Product-Settings The standalone PowerToys Settings application Resolution-By Design Reported behavior reflects what the code is expected to do; it does not imply the design is good.

Comments

@PesBandi
Copy link
Contributor

Microsoft PowerToys version

0.77.0

Installation method

GitHub, PowerToys auto-update

Running as admin

Yes

Area(s) with issue?

Settings

Steps to reproduce

Look at the left pane. It is not correctly sorted.

✔️ Expected Behavior

Color Picker should be before Command Not Found.

❌ Actual Behavior

No response

Other Software

No response

@PesBandi PesBandi added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Jan 22, 2024
@Aaron-Junker Aaron-Junker added Good first issue Good for newcomers. Product-Settings The standalone PowerToys Settings application Cost-Small Small work item - 0-8 hours of work labels Jan 22, 2024
@sanidhyas3s
Copy link
Contributor

Would try to work on this!

@Jay-o-Way
Copy link
Collaborator

Jay-o-Way commented Jan 23, 2024

Hi @sanidhyas3s that sounds great! Changing the order of these two items is easy. If you think of tackling the order of all the menu items, what would be your plan to solve this? I think it's more complicated than it seems, because some modules are translated and some ar not.

@Jay-o-Way Jay-o-Way removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Jan 23, 2024
@sanidhyas3s
Copy link
Contributor

@Jay-o-Way To sort based on the module names in the language being used. Can there be an issue in that?

@Jay-o-Way
Copy link
Collaborator

Jay-o-Way commented Jan 23, 2024

The larger issue is #23763. So if wou want to try that, I would consider this issue a part of that.
#12388 is also about the menu, but is too broad for this.

@sanidhyas3s
Copy link
Contributor

Ok, would first need to finish setting up PowerToys in Visual Studio, then would try solving it. Any help to speed things up would be nice!

@Jay-o-Way
Copy link
Collaborator

Jay-o-Way commented Jan 23, 2024

@sanidhyas3s Nice. The project is big and there's a big list to be done to prepare. Looking at your profile, I assume you know the basics. https://github.com/microsoft/PowerToys/blob/main/doc%2Fdevdocs%2Freadme.md will help you on your way. The navigation is in src/settings-ui/Settings.UI/SettingsXAML/Views/ShellPage.xaml

@sanidhyas3s
Copy link
Contributor

sanidhyas3s commented Jan 23, 2024

@Jay-o-Way Not sure if this is the right place to ask, but after having set-up PowerToys/Visual Studio, after making some test changes to the code and building PowerToys (or just the settings) from the sln doesn't reflect the changes in the .exe produced (or the settings window that opens in the debug mode). Am I missing something or doing something wrong?

@Jay-o-Way
Copy link
Collaborator

Jay-o-Way commented Jan 23, 2024

@sanidhyas3s

  1. Make sure you have the latest version in your repository and branch. Your main branch is 730 commits behind microsoft/PowerToys:main.
  2. Don't know what your approach in the code is - got a link to your branch? - but if the change is "valid", you should be able to see it when Debugging. How do you test it? Changing your OS or App language?

@sanidhyas3s
Copy link
Contributor

@Jay-o-Way The repo is updated, just my online fork isn't, that is not the issue anyways.

What I meant by test changes was just random changes like changing the order of items manually in ShellPage.xaml to check if the changes I am making are getting reflected in x64\Release\PowerToys.exe, but they are not for some reason.

This is exactly what I am doing:

  • Open PowerToys.sln in Visual Studio.
  • Select Release in Solutions Configurations and PowerToys.Settings in Startup Projects
  • Hitting the play button adjacent to these settings.
  • PowerToys settings open up after build completion automatically, but no changes reflected.

Also alternatively building using Build>Build Solution and then running x64\Release\PowerToys.exe give me the same results.

Can you please help me here, new to Visual Studio and using solutions to compile applications.

@Jay-o-Way

This comment was marked as outdated.

@Aaron-Junker
Copy link
Collaborator

Does the compilation succeed? You can also build just the settings projects and see if that helps.

@sanidhyas3s
Copy link
Contributor

sanidhyas3s commented Jan 29, 2024

@Aaron-Junker I do have 10 errors displaying after compilation, but the Build finishes.

These are the errors:
image
Also I am currently building with "Release".
I guess I had to build with "Debug" selected, wasn't mentioned clearly in the readme.
Nevermind, changes reflect now, will try to get this solved now asap.

Again, sorry for filling up the issue discussion with my doubts.

@Jay-o-Way Jay-o-Way added the Status-In progress This issue or work-item is under development label Jan 29, 2024
sanidhyas3s added a commit to sanidhyas3s/PowerToys that referenced this issue Jan 30, 2024
The Navigation Pane items are now sorted
alphabetically based on their Display Names.

Fixes microsoft#31089, microsoft#23763
@sanidhyas3s
Copy link
Contributor

I have solved this (can verify, atleast for English).

I would like to test if this works for other languages, though I am not sure how can I do that, if I change my system language preferences, the actual PowerToys (the one I installed normally) does change its display language, but not the one I am building and running.

sanidhyas3s added a commit to sanidhyas3s/PowerToys that referenced this issue Jan 30, 2024
The Navigation Pane items are now sorted
alphabetically based on their Display Names.

Fixes microsoft#31089, microsoft#23763
sanidhyas3s added a commit to sanidhyas3s/PowerToys that referenced this issue Jan 31, 2024
A common helper function is made which
sorts the items for both the shell pages.

Fixes microsoft#31089, microsoft#23763
@crutkas crutkas added Resolution-By Design Reported behavior reflects what the code is expected to do; it does not imply the design is good. and removed Good first issue Good for newcomers. Status-In progress This issue or work-item is under development labels Feb 29, 2024
@crutkas
Copy link
Member

crutkas commented Feb 29, 2024

Hi all, sorry but this is intentionally by design.

@crutkas crutkas closed this as completed Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cost-Small Small work item - 0-8 hours of work Issue-Bug Something isn't working Product-Settings The standalone PowerToys Settings application Resolution-By Design Reported behavior reflects what the code is expected to do; it does not imply the design is good.
Projects
None yet
Development

No branches or pull requests

5 participants