From 796a8e03e038d77bb50a623bf3857fc3b5899406 Mon Sep 17 00:00:00 2001
From: Daniel Zayas <danielzayas@Daniels-MacBook-Pro.local>
Date: Thu, 4 Dec 2025 10:26:58 -0800
Subject: [PATCH] update merge_tasks.py to _validate_record contains
 REQUIRED_FIELDS

---
 curation/swe_task_crawling/merge_tasks.py | 34 ++++++++++++++++++++---
 1 file changed, 30 insertions(+), 4 deletions(-)

diff --git a/curation/swe_task_crawling/merge_tasks.py b/curation/swe_task_crawling/merge_tasks.py
index bc2a6d9..8b049ea 100644
--- a/curation/swe_task_crawling/merge_tasks.py
+++ b/curation/swe_task_crawling/merge_tasks.py
@@ -5,9 +5,12 @@
 import argparse
 import json
 from pathlib import Path
+from typing import Dict, List, Set
 
+REQUIRED_FIELDS = ("instance_id", "repo", "pull_number")
 
-def merge_jsonl_files(input_folder: str, output_file: str = None):
+
+def merge_jsonl_files(input_folder: str, output_file: str = None, validate: bool = False):
     """
     Merge all .jsonl files from input_folder into a single output file.
     
@@ -34,10 +37,13 @@ def merge_jsonl_files(input_folder: str, output_file: str = None):
         return False
     
     # Set default output file name if not provided
+    if output_file is None:
+        output_file = input_path / "merged_tasks.jsonl"
     output_file = Path(output_file)
     
     # Merge all files
     try:
+        seen_ids: Set[str] = set()
         with open(output_file, 'w', encoding='utf-8') as outf:
             for jsonl_file in sorted(jsonl_files):
                 with open(jsonl_file, 'r', encoding='utf-8') as inf:
@@ -46,8 +52,10 @@ def merge_jsonl_files(input_folder: str, output_file: str = None):
                         if line:  # Skip empty lines
                             # Validate JSON format
                             try:
-                                json.loads(line)
-                                outf.write(line + '\n')
+                                record = json.loads(line)
+                                if validate:
+                                    _validate_record(record, jsonl_file.name, seen_ids)
+                                outf.write(json.dumps(record, ensure_ascii=False) + '\n')
                             except json.JSONDecodeError as e:
                                 print(f"  Warning: Invalid JSON in {jsonl_file.name}: {e}")
                                 continue
@@ -57,6 +65,19 @@ def merge_jsonl_files(input_folder: str, output_file: str = None):
         return False
 
 
+def _validate_record(record: Dict, source_name: str, seen_ids: Set[str]) -> None:
+    """Ensure a merged record has required fields and a unique instance id."""
+    missing: List[str] = [field for field in REQUIRED_FIELDS if field not in record]
+    if missing:
+        raise ValueError(
+            f"{source_name}: missing required fields {missing} for instance {record.get('instance_id')}"
+        )
+    instance_id = record["instance_id"]
+    if instance_id in seen_ids:
+        raise ValueError(f"Duplicate instance_id '{instance_id}' found while merging ({source_name}).")
+    seen_ids.add(instance_id)
+
+
 def main():
     """Main function to handle command line arguments and execute merge."""
     parser = argparse.ArgumentParser(
@@ -75,11 +96,16 @@ def main():
         dest='output_file',
         help='Output file path (default: merged_tasks.jsonl in input folder)'
     )
+    parser.add_argument(
+        '--validate',
+        action='store_true',
+        help='Validate required fields and ensure unique instance_ids while merging.'
+    )
     
     args = parser.parse_args()
     
     # Execute merge
-    success = merge_jsonl_files(args.input_folder, args.output_file)
+    success = merge_jsonl_files(args.input_folder, args.output_file, validate=args.validate)
     
     if not success:
         exit(1)