-
Notifications
You must be signed in to change notification settings - Fork 448
Update README.md #2141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #2141
Conversation
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
Also added a comment for KDL |
- `comments.json`: comment strings to be embedded in the generated .d.ts files. | ||
- `deprecatedMessage.json`: the reason why one type is deprecated. | ||
|
||
npm run ts-changelog -- @types/web 0.0.2 0.0.23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still exists and probably part of the manual job? IDK what people actually do, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And should we document how the manual job goes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think no one uses it ... I never used it
Maybe it is only for maintainers, Idk even what it does, I never had to generate a change log.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm honestly not sure it matters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I looked and I don't think we have used this in recent memory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the earlier mismerge, I noticed the syntax error too late.
I'll merge this in now, as I'm pretty certain we don't use the script, and it's probably worth relooking at that later. But at the moment I don't want the readme to be broken 😑
I have fixed it @jakebailey, @saschanaz