Skip to content

Conversation

Bashamega
Copy link
Contributor

I have fixed it @jakebailey, @saschanaz

Copy link
Contributor

github-actions bot commented Sep 6, 2025

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

@Bashamega
Copy link
Contributor Author

Also added a comment for KDL

- `comments.json`: comment strings to be embedded in the generated .d.ts files.
- `deprecatedMessage.json`: the reason why one type is deprecated.

npm run ts-changelog -- @types/web 0.0.2 0.0.23
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still exists and probably part of the manual job? IDK what people actually do, though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And should we document how the manual job goes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think no one uses it ... I never used it
Maybe it is only for maintainers, Idk even what it does, I never had to generate a change log.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm honestly not sure it matters

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I looked and I don't think we have used this in recent memory

jakebailey
jakebailey previously approved these changes Sep 6, 2025
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the earlier mismerge, I noticed the syntax error too late.

I'll merge this in now, as I'm pretty certain we don't use the script, and it's probably worth relooking at that later. But at the moment I don't want the readme to be broken 😑

@jakebailey jakebailey merged commit 689f1bb into microsoft:main Sep 6, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants