Cleanup

Author: jakebailey

src/compiler/parser.ts

@@ -10628,7 +10628,7 @@ export function processPragmasIntoFields(context: PragmaContext, reportDiagnosti
                     const { types, lib, path, ["resolution-mode"]: res, preserve: _preserve } = arg.arguments;
                     const preserve = _preserve === "true" ? true : undefined;
                     if (arg.arguments["no-default-lib"] === "true") {
-                        // Ignore.
+                        // This has been removed; parse but ignore it.
                     }
                     else if (types) {
                         const parsed = parseResolutionMode(res, types.pos, types.end, reportDiagnostic);

src/harness/fourslashImpl.ts

@@ -423,27 +423,23 @@ export class TestState {
                 this.addMatchedInputFile(importedFilePath, exts);
             });
 
-            // Check if no-default-lib flag is false and if so add default library
-            // TODO(jakebailey): fix no-default-lib
-            if (!resolvedResult.isLibFile) {
-                this.languageServiceAdapterHost.addScript(
-                    libName(Harness.Compiler.defaultLibFileName),
-                    Harness.Compiler.getDefaultLibrarySourceFile()!.text,
-                    /*isRootFile*/ false,
-                );
+            this.languageServiceAdapterHost.addScript(
+                libName(Harness.Compiler.defaultLibFileName),
+                Harness.Compiler.getDefaultLibrarySourceFile()!.text,
+                /*isRootFile*/ false,
+            );
 
-                compilationOptions.lib?.forEach(fileName => {
-                    const libFile = Harness.Compiler.getDefaultLibrarySourceFile(fileName);
-                    ts.Debug.assertIsDefined(libFile, `Could not find lib file '${fileName}'`);
-                    if (libFile) {
-                        this.languageServiceAdapterHost.addScript(
-                            libName(fileName),
-                            libFile.text,
-                            /*isRootFile*/ false,
-                        );
-                    }
-                });
-            }
+            compilationOptions.lib?.forEach(fileName => {
+                const libFile = Harness.Compiler.getDefaultLibrarySourceFile(fileName);
+                ts.Debug.assertIsDefined(libFile, `Could not find lib file '${fileName}'`);
+                if (libFile) {
+                    this.languageServiceAdapterHost.addScript(
+                        libName(fileName),
+                        libFile.text,
+                        /*isRootFile*/ false,
+                    );
+                }
+            });
         }
         else {
             // resolveReference file-option is not specified then do not resolve any files and include all inputFiles