Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build inconsistent with different .NET SDK versions installed (example: .NET 8 RC2) #212

Closed
rjmurillo opened this issue Nov 10, 2023 · 4 comments

Comments

@rjmurillo
Copy link
Member

While running a build with .NET 8 RC2 SDK installed, the build.cmd can fail. Specifying the SDK tool chain in global.json to use .NET 7 SDK resolves this issue. See #211 for fix.

C:\Program Files\dotnet\sdk\8.0.100-rc.2.23502.2\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(106,33): error MSB4030: "true -p:TrimUnusedDependenc
ies=true" is an invalid value for the "PublishTrimmed" parameter of the "ProcessFrameworkReferences" task. The "PublishTrimmed" parameter is of type "System.Boolean". [E:\src\GitHub\rjmur
illo\VirtualClient\src\VirtualClient\VirtualClient.Dependencies\VirtualClient.Dependencies.csproj]
C:\Program Files\dotnet\sdk\8.0.100-rc.2.23502.2\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(106,33): error MSB4030: "true -p:TrimUnusedDependenc
ies=true" is an invalid value for the "PublishTrimmed" parameter of the "ProcessFrameworkReferences" task. The "PublishTrimmed" parameter is of type "System.Boolean". [E:\src\GitHub\rjmur
illo\VirtualClient\src\VirtualClient\VirtualClient.Contracts\VirtualClient.Contracts.csproj]
C:\Program Files\dotnet\sdk\8.0.100-rc.2.23502.2\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(106,33): error MSB4030: "true -p:TrimUnusedDependenc
ies=true" is an invalid value for the "PublishTrimmed" parameter of the "ProcessFrameworkReferences" task. The "PublishTrimmed" parameter is of type "System.Boolean". [E:\src\GitHub\rjmur
illo\VirtualClient\src\VirtualClient\VirtualClient.Monitors\VirtualClient.Monitors.csproj]
C:\Program Files\dotnet\sdk\8.0.100-rc.2.23502.2\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(106,33): error MSB4030: "true -p:TrimUnusedDependenc
ies=true" is an invalid value for the "PublishTrimmed" parameter of the "ProcessFrameworkReferences" task. The "PublishTrimmed" parameter is of type "System.Boolean". [E:\src\GitHub\rjmur
illo\VirtualClient\src\VirtualClient\VirtualClient.Api\VirtualClient.Api.csproj]
C:\Program Files\dotnet\sdk\8.0.100-rc.2.23502.2\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(106,33): error MSB4030: "true -p:TrimUnusedDependenc
ies=true" is an invalid value for the "PublishTrimmed" parameter of the "ProcessFrameworkReferences" task. The "PublishTrimmed" parameter is of type "System.Boolean". [E:\src\GitHub\rjmur
illo\VirtualClient\src\VirtualClient\VirtualClient.Common\VirtualClient.Common.csproj]
C:\Program Files\dotnet\sdk\8.0.100-rc.2.23502.2\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(106,33): error MSB4030: "true -p:TrimUnusedDependenc
ies=true" is an invalid value for the "PublishTrimmed" parameter of the "ProcessFrameworkReferences" task. The "PublishTrimmed" parameter is of type "System.Boolean". [E:\src\GitHub\rjmur
illo\VirtualClient\src\VirtualClient\VirtualClient.Actions\VirtualClient.Actions.csproj]
C:\Program Files\dotnet\sdk\8.0.100-rc.2.23502.2\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(106,33): error MSB4030: "true -p:TrimUnusedDependenc
ies=true" is an invalid value for the "PublishTrimmed" parameter of the "ProcessFrameworkReferences" task. The "PublishTrimmed" parameter is of type "System.Boolean". [E:\src\GitHub\rjmur
illo\VirtualClient\src\VirtualClient\VirtualClient.Core\VirtualClient.Core.csproj]
C:\Program Files\dotnet\sdk\8.0.100-rc.2.23502.2\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(106,33): error MSB4030: "true -p:TrimUnusedDependenc
ies=true" is an invalid value for the "PublishTrimmed" parameter of the "ProcessFrameworkReferences" task. The "PublishTrimmed" parameter is of type "System.Boolean". [E:\src\GitHub\rjmur
illo\VirtualClient\src\VirtualClient\VirtualClient.Main\VirtualClient.Main.csproj]
@yangpanMS
Copy link
Contributor

yangpanMS commented Nov 10, 2023

@rjmurillo we plan to skip .NET 7 and go directly to .NET 8 after the release in .NET conf. Should happen in 1-2 weeks, I will do the conversion, and resolve this after that's done.

@rjmurillo
Copy link
Member Author

@yangpanMS #211 updated to specify .NET 6 tool chain instead of 7. This is required if you're running .NET 8 SDK as the build breaks without it.

@yangpanMS
Copy link
Contributor

yangpanMS commented Nov 10, 2023

Thanks Richard. I approved. Most of our team is still on .NET 6. When moving to .net 8 I will address the build breaks.

@yangpanMS
Copy link
Contributor

Closing as it is addressed in #214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants