Fix deployment E2E test matrix enumeration - #19412
Conversation
Remove the accidental Partition trait that switched the deployment E2E project from class-based splitting to collection mode. Add a focused infrastructure guard that keeps the project in class mode without depending on an exact class count. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 47204ae2-7a7c-4b5f-b191-51e9d727eabc
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19412Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19412" |
Keep the fix scoped to removing the accidental Partition trait. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 47204ae2-7a7c-4b5f-b191-51e9d727eabc
|
/deployment-test |
|
🚀 Deployment tests starting on PR #19412... This will deploy to real Azure infrastructure. Results will be posted here when complete. |
There was a problem hiding this comment.
Pull request overview
Fixes Deployment E2E enumeration so tests generate one matrix job per class.
Changes:
- Removes the accidental
Partitiontrait. - Retains deployment and Azure provider traits.
- Adds whitespace to the existing partition guard test.
Show a summary per file
| File | Description |
|---|---|
AksPersistentVolumeDeploymentTests.cs |
Restores class-mode enumeration. |
ScanTestPartitionsFromSourceGuardTests.cs |
Adds whitespace; no regression assertion. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 47204ae2-7a7c-4b5f-b191-51e9d727eabc
Tests selector (audit mode)The full test matrix and all jobs still run in audit mode. The tests and jobs below are what selective CI would run under enforcement. 1 / 101 test projects · 1 job, from 1 changed file. Selected test projects (1 / 101)
Selected jobs (1)
How these were chosen — grouped by what changed🧪 Job reasons
Selection computed for commit |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
74a770f
into
main
|
✅ No documentation update needed. Step 5 branch taken:
|
|
/backport to release/13.5 |
|
Started backporting to |
Description
The Deployment E2E workflow stopped generating one matrix job per test class after
AksPersistentVolumeDeploymentTestsintroduced aPartitiontrait. The enumeration pipeline treats the presence of any partition trait as partition mode, so the affected workflow run collapsed the active deployment tests into two buckets.This removes the accidental partition trait while retaining the deployment category and Azure provider traits.
Validation:
Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?