Skip to content

Fix deployment E2E test matrix enumeration - #19412

Merged
Sébastien Ros (sebastienros) merged 3 commits into
mainfrom
mitchdenny-fix-deployment-e2e-matrix
Aug 15, 2026
Merged

Fix deployment E2E test matrix enumeration#19412
Sébastien Ros (sebastienros) merged 3 commits into
mainfrom
mitchdenny-fix-deployment-e2e-matrix

Conversation

@mitchdenny

@mitchdenny Mitch Denny (mitchdenny) commented Aug 15, 2026

Copy link
Copy Markdown
Member

Description

The Deployment E2E workflow stopped generating one matrix job per test class after AksPersistentVolumeDeploymentTests introduced a Partition trait. The enumeration pipeline treats the presence of any partition trait as partition mode, so the affected workflow run collapsed the active deployment tests into two buckets.

This removes the accidental partition trait while retaining the deployment category and Azure provider traits.

Validation:

  • The existing partition source guard passes.
  • The source partition scan selects class mode.
  • The CI partition generator emits 42 active class jobs and no collection buckets after applying the standard quarantine and outerloop exclusions.

Fixes # (issue)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No

Remove the accidental Partition trait that switched the deployment E2E project from class-based splitting to collection mode. Add a focused infrastructure guard that keeps the project in class mode without depending on an exact class count.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 47204ae2-7a7c-4b5f-b191-51e9d727eabc
Copilot AI balanced review requested due to automatic review settings August 15, 2026 06:58
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19412

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19412"

@github-actions github-actions Bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 15, 2026
Keep the fix scoped to removing the accidental Partition trait.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 47204ae2-7a7c-4b5f-b191-51e9d727eabc
@mitchdenny

Copy link
Copy Markdown
Member Author

/deployment-test

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Deployment tests starting on PR #19412...

This will deploy to real Azure infrastructure. Results will be posted here when complete.

View workflow run

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes Deployment E2E enumeration so tests generate one matrix job per class.

Changes:

  • Removes the accidental Partition trait.
  • Retains deployment and Azure provider traits.
  • Adds whitespace to the existing partition guard test.
Show a summary per file
File Description
AksPersistentVolumeDeploymentTests.cs Restores class-mode enumeration.
ScanTestPartitionsFromSourceGuardTests.cs Adds whitespace; no regression assertion.

Review details

  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Balanced

@github-actions
github-actions Bot temporarily deployed to deployment-testing August 15, 2026 07:03 Inactive
@github-actions

This comment has been minimized.

@github-actions
github-actions Bot temporarily deployed to deployment-testing August 15, 2026 07:09 Inactive
@github-actions
github-actions Bot temporarily deployed to deployment-testing August 15, 2026 07:09 Inactive
@github-actions
github-actions Bot temporarily deployed to deployment-testing August 15, 2026 07:09 Inactive
@github-actions
github-actions Bot temporarily deployed to deployment-testing August 15, 2026 07:09 Inactive
@github-actions
github-actions Bot temporarily deployed to deployment-testing August 15, 2026 07:09 Inactive
@github-actions
github-actions Bot temporarily deployed to deployment-testing August 15, 2026 07:09 Inactive
@github-actions
github-actions Bot temporarily deployed to deployment-testing August 15, 2026 07:09 Inactive
@github-actions
github-actions Bot temporarily deployed to deployment-testing August 15, 2026 07:09 Inactive
@github-actions
github-actions Bot temporarily deployed to deployment-testing August 15, 2026 07:09 Inactive
@github-actions
github-actions Bot temporarily deployed to deployment-testing August 15, 2026 07:09 Inactive
@github-actions
github-actions Bot temporarily deployed to deployment-testing August 15, 2026 07:09 Inactive
@github-actions
github-actions Bot temporarily deployed to deployment-testing August 15, 2026 07:09 Inactive
@github-actions
github-actions Bot temporarily deployed to deployment-testing August 15, 2026 07:09 Inactive
@github-actions
github-actions Bot temporarily deployed to deployment-testing August 15, 2026 07:09 Inactive
@github-actions
github-actions Bot temporarily deployed to deployment-testing August 15, 2026 07:09 Inactive
@github-actions
github-actions Bot temporarily deployed to deployment-testing August 15, 2026 07:09 Inactive
@github-actions
github-actions Bot temporarily deployed to deployment-testing August 15, 2026 07:09 Inactive
@github-actions
github-actions Bot temporarily deployed to deployment-testing August 15, 2026 07:09 Inactive
@github-actions
github-actions Bot temporarily deployed to deployment-testing August 15, 2026 07:09 Inactive
@github-actions
github-actions Bot temporarily deployed to deployment-testing August 15, 2026 07:09 Inactive
@github-actions
github-actions Bot temporarily deployed to deployment-testing August 15, 2026 07:09 Inactive
@github-actions
github-actions Bot temporarily deployed to deployment-testing August 15, 2026 07:09 Inactive
@github-actions
github-actions Bot temporarily deployed to deployment-testing August 15, 2026 07:09 Inactive
@github-actions
github-actions Bot temporarily deployed to deployment-testing August 15, 2026 07:09 Inactive
@github-actions
github-actions Bot temporarily deployed to deployment-testing August 15, 2026 07:09 Inactive
@github-actions
github-actions Bot temporarily deployed to deployment-testing August 15, 2026 07:09 Inactive
@github-actions
github-actions Bot temporarily deployed to deployment-testing August 15, 2026 07:09 Inactive
@github-actions
github-actions Bot temporarily deployed to deployment-testing August 15, 2026 07:09 Inactive
@github-actions
github-actions Bot temporarily deployed to deployment-testing August 15, 2026 07:09 Inactive
@github-actions
github-actions Bot temporarily deployed to deployment-testing August 15, 2026 07:09 Inactive
@github-actions
github-actions Bot temporarily deployed to deployment-testing August 15, 2026 07:09 Inactive
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 47204ae2-7a7c-4b5f-b191-51e9d727eabc
Copilot AI review requested due to automatic review settings August 15, 2026 07:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@github-actions

Copy link
Copy Markdown
Contributor

Tests selector (audit mode)

The full test matrix and all jobs still run in audit mode. The tests and jobs below are what selective CI would run under enforcement.

1 / 101 test projects · 1 job, from 1 changed file.

Selected test projects (1 / 101)

Aspire.Deployment.EndToEnd.Tests

Selected jobs (1)

deployment-e2e


How these were chosen — grouped by what changed

🧪 tests/Aspire.Deployment.EndToEnd.Tests/AksPersistentVolumeDeploymentTests.cs (changed test)
1 directly: Aspire.Deployment.EndToEnd.Tests

Job reasons

Job Triggered by
deployment-e2e tests/Aspire.Deployment.EndToEnd.Tests/AksPersistentVolumeDeploymentTests.cs

Selection computed for commit b735153.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@sebastienros
Sébastien Ros (sebastienros) merged commit 74a770f into main Aug 15, 2026
1443 of 1457 checks passed
@sebastienros
Sébastien Ros (sebastienros) deleted the mitchdenny-fix-deployment-e2e-matrix branch August 15, 2026 17:15
@github-actions github-actions Bot added this to the 13.6 milestone Aug 15, 2026
@aspire-repo-bot

Copy link
Copy Markdown
Contributor

✅ No documentation update needed.

Step 5 branch taken: docs_optional → test_only

  • Triggered signals: none (signal_count: 0, triggered_signals: []).
  • Allowlist category justification: all 1 changed file matches tests/**tests/Aspire.Deployment.EndToEnd.Tests/AksPersistentVolumeDeploymentTests.cs (a 1-line trait removal fixing E2E test matrix enumeration). only_test_or_build_changes is true and no source files under src/ changed.
  • This is a pure test-infrastructure fix (removing an accidental Partition trait so the deployment E2E CI matrix correctly enumerates one job per test class) with no user-facing behavior, API, CLI, or documentation surface change. No docs PR is warranted.

@mitchdenny

Copy link
Copy Markdown
Member Author

/backport to release/13.5

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/13.5 (link to workflow run)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants