Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextMessageTerminationCondition for agentchat #5742

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

EItanya
Copy link
Contributor

@EItanya EItanya commented Feb 27, 2025

Why are these changes needed?

Reasons are described in #5732

Related issue number

Closes #5732

Checks

@EItanya
Copy link
Contributor Author

EItanya commented Feb 27, 2025

@ekzhu

@EItanya EItanya force-pushed the text-message-termination branch from 162ae84 to fb2fd1c Compare February 27, 2025 18:50
@EItanya
Copy link
Contributor Author

EItanya commented Feb 27, 2025

Hey @ekzhu, I found a bit of a problem with this setup. The initial task that a chat begins with is passed through the system as TextMessage with a source set to user and that ends up terminating the chat. I have a local version which includes a config of exclude_sources: list[str] = [] which allows the user to skip certain sources if they want. But it may just be worth always skipping the user source in this case?

Edit:
Just to confirm that once I added this it worked as expected.

@ekzhu
Copy link
Collaborator

ekzhu commented Feb 27, 2025

As describe in the issue #5732 we should have a source parameter for the condition:

TextMessageTermination(source="assistant")

So we can filter by source.

@EItanya
Copy link
Contributor Author

EItanya commented Feb 27, 2025

Ok, pushed the requested impl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TextMessageTermination Condition
2 participants