fix: Update SKChatCompletionAdapter message conversion #5749
+267
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lspinheiro
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5749 +/- ##
==========================================
+ Coverage 74.96% 75.04% +0.08%
==========================================
Files 175 176 +1
Lines 11158 11166 +8
==========================================
+ Hits 8365 8380 +15
+ Misses 2793 2786 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ekzhu
reviewed
Feb 28, 2025
python/packages/autogen-core/src/autogen_core/models/_model_client.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The PR introduces two changes.
The first change is adding a name attribute to
FunctionExecutionResult. The motivation is that semantic kernel requires it for their function result interface and it seemed like a easy modification asFunctionExecutionResultis always created in the context of aFunctionCallwhich will contain the name. I'm unsure if there was a motivation to keep it out but this change makes it easier to trace which tool the result refers to and also increases api compatibility with SK.The second change is an update to how messages are mapped from autogen to semantic kernel, which includes an update/fix in the processing of function results.
Related issue number
Related to #5675 but wont fix the underlying issue of anthropic requiring tools during AssistantAgent reflection.
Checks