Allow cross domain authorization by default and add unit tests (#427)

* Allow cross origin auth by default and add units

* Reverted unnecessary changes

* removed extra lines

* Remove asyncs

* Bump version

* Fix gitignore

Author: EzzhevNikita

.gitignore

@@ -6,7 +6,7 @@ _def
 samples/*.js 
 
 # Tests
-test/**.js
+test/**/*.js
 
 # Logs
 logs

api/handlers/basiccreds.ts

@@ -5,7 +5,7 @@ import ifm = require('../interfaces/common/VsoBaseInterfaces');
 import * as resthandlers from 'typed-rest-client/Handlers'; 
 
 export class BasicCredentialHandler extends resthandlers.BasicCredentialHandler implements ifm.IRequestHandler {
-    constructor(username: string, password: string, allowCrossOriginAuthentication?: boolean) {
+    constructor(username: string, password: string, allowCrossOriginAuthentication: boolean = true) {
         super(username, password, allowCrossOriginAuthentication);
     }
 }

api/handlers/bearertoken.ts

@@ -5,7 +5,7 @@ import ifm = require('../interfaces/common/VsoBaseInterfaces');
 import * as resthandlers from 'typed-rest-client/Handlers'; 
 
 export class BearerCredentialHandler extends resthandlers.BearerCredentialHandler implements ifm.IRequestHandler {
-    constructor(token: string, allowCrossOriginAuthentication?: boolean) {
+    constructor(token: string, allowCrossOriginAuthentication: boolean = true) {
         super(token, allowCrossOriginAuthentication);
     }
 }

api/handlers/personalaccesstoken.ts

@@ -5,7 +5,7 @@ import ifm = require('../interfaces/common/VsoBaseInterfaces');
 import * as resthandlers from 'typed-rest-client/Handlers'; 
 
 export class PersonalAccessTokenCredentialHandler extends resthandlers.PersonalAccessTokenCredentialHandler implements ifm.IRequestHandler {
-    constructor(token: string, allowCrossOriginAuthentication?: boolean) {
+    constructor(token: string, allowCrossOriginAuthentication: boolean = true) {
         super(token, allowCrossOriginAuthentication);
     }
 }

package-lock.json

@@ -1,7 +1,7 @@
 {
     "name": "azure-devops-node-api",
     "description": "Node client for Azure DevOps and TFS REST APIs",
-    "version": "10.2.0",
+    "version": "10.2.1",
     "main": "./WebApi.js",
     "types": "./WebApi.d.ts",
     "scripts": {

package.json

@@ -299,3 +299,35 @@ describe('WebApi Units', function () {
         assert.equal(myWebApi.isNoProxyHost('https://my-other-tfs-instance.host/myproject'), false);
     });
 });
+
+describe('Auth Handlers Units', function () {
+    it('cross origin authenthication should be allowed by default in BasicCredentialHandler', () => {
+        const basicAuthHandler = WebApi.getBasicHandler('user', 'password');
+        assert(basicAuthHandler['allowCrossOriginAuthentication'] === true);
+    });
+
+    it('cross origin authenthication should be allowed by default in BearerCredentialHandler', () => {
+        const bearerAuthHandler = WebApi.getBearerHandler('0000000000000000000000000000000000000000');
+        assert(bearerAuthHandler['allowCrossOriginAuthentication'] === true);
+    });
+
+    it('cross origin authenthication should be allowed by default in PersonalAccessTokenCredentialHandler', () => {
+        const personalAccessTokenAuthHandler = WebApi.getPersonalAccessTokenHandler('0000000000000000000000000000000000000000');
+        assert(personalAccessTokenAuthHandler['allowCrossOriginAuthentication']  === true);
+    });
+
+    it('cross origin authenthication could be disabled in BasicCredentialHandler', () => {
+        const basicAuthHandler = WebApi.getBasicHandler('user', 'password', false);  
+        assert(basicAuthHandler['allowCrossOriginAuthentication'] === false);
+    });
+
+    it('cross origin authenthication could be disabled in BearerCredentialHandler', () => {
+        const bearerAuthHandler = WebApi.getBearerHandler('0000000000000000000000000000000000000000', false);
+        assert(bearerAuthHandler['allowCrossOriginAuthentication'] === false);
+    });
+
+    it('cross origin authenthication could be disabled in PersonalAccessTokenCredentialHandler', () => {
+        const personalAccessTokenAuthHandler = WebApi.getPersonalAccessTokenHandler('0000000000000000000000000000000000000000', false);
+        assert(personalAccessTokenAuthHandler['allowCrossOriginAuthentication'] === false);
+    });
+});