Skip to content

Commit ce9078b

Browse files
committed
refactor event args to one class
1 parent bb720ad commit ce9078b

5 files changed

Lines changed: 11 additions & 38 deletions

File tree

cs/src/Connections/ITunnelClient.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ Task ConnectAsync(
202202
/// configured <see cref="TunnelConnectionOptions.KeepAliveIntervalInSeconds"/>. This callback is only invoked
203203
/// if the keep-alive interval is greater than 0.
204204
/// </remarks>
205-
public event EventHandler<SshKeepAliveFailureEventArgs>? KeepAliveFailed;
205+
public event EventHandler<SshKeepAliveEventArgs>? KeepAliveFailed;
206206

207207
/// <summary>
208208
/// Event raised when a keep-alive message response is received.
@@ -212,6 +212,6 @@ Task ConnectAsync(
212212
/// configured <see cref="TunnelConnectionOptions.KeepAliveIntervalInSeconds"/>. This callback is only invoked
213213
/// if the keep-alive interval is greater than 0.
214214
/// </remarks>
215-
public event EventHandler<SshKeepAliveSuccessEventArgs>? KeepAliveSucceeded;
215+
public event EventHandler<SshKeepAliveEventArgs>? KeepAliveSucceeded;
216216
}
217217

cs/src/Connections/ITunnelHost.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ Task ConnectAsync(
136136
/// configured <see cref="TunnelConnectionOptions.KeepAliveIntervalInSeconds"/>. This callback is only invoked
137137
/// if the keep-alive interval is greater than 0.
138138
/// </remarks>
139-
public event EventHandler<SshKeepAliveFailureEventArgs>? KeepAliveFailed;
139+
public event EventHandler<SshKeepAliveEventArgs>? KeepAliveFailed;
140140

141141
/// <summary>
142142
/// Event raised when a keep-alive message response is received.
@@ -146,5 +146,5 @@ Task ConnectAsync(
146146
/// configured <see cref="TunnelConnectionOptions.KeepAliveIntervalInSeconds"/>. This callback is only invoked
147147
/// if the keep-alive interval is greater than 0.
148148
/// </remarks>
149-
public event EventHandler<SshKeepAliveSuccessEventArgs>? KeepAliveSucceeded;
149+
public event EventHandler<SshKeepAliveEventArgs>? KeepAliveSucceeded;
150150
}

cs/src/Connections/SshKeepAliveSuccessEventArgs.cs renamed to cs/src/Connections/SshKeepAliveEventArgs.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@ namespace Microsoft.DevTunnels.Connections;
1010
/// <summary>
1111
/// Event raised when a keep-alive message respose is not received.
1212
/// </summary>
13-
public class SshKeepAliveSuccessEventArgs : EventArgs
13+
public class SshKeepAliveEventArgs : EventArgs
1414
{
1515
/// <summary>
16-
/// Create a new instance of <see cref="SshKeepAliveSuccessEventArgs"/>.
16+
/// Create a new instance of <see cref="SshKeepAliveEventArgs"/>.
1717
/// </summary>
18-
public SshKeepAliveSuccessEventArgs(int count)
18+
public SshKeepAliveEventArgs(int count)
1919
{
2020
Count = count;
2121
}

cs/src/Connections/SshKeepAliveFailureEventArgs.cs

Lines changed: 0 additions & 27 deletions
This file was deleted.

cs/src/Connections/TunnelConnection.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ protected virtual void ValidateAccessToken()
265265
/// configured <see cref="TunnelConnectionOptions.KeepAliveIntervalInSeconds"/>. This callback is only invoked
266266
/// if the keep-alive interval is greater than 0.
267267
/// </remarks>
268-
public event EventHandler<SshKeepAliveFailureEventArgs>? KeepAliveFailed;
268+
public event EventHandler<SshKeepAliveEventArgs>? KeepAliveFailed;
269269

270270
/// <summary>
271271
/// Event raised when a keep-alive message response is received.
@@ -275,7 +275,7 @@ protected virtual void ValidateAccessToken()
275275
/// configured <see cref="TunnelConnectionOptions.KeepAliveIntervalInSeconds"/>. This callback is only invoked
276276
/// if the keep-alive interval is greater than 0.
277277
/// </remarks>
278-
public event EventHandler<SshKeepAliveSuccessEventArgs>? KeepAliveSucceeded;
278+
public event EventHandler<SshKeepAliveEventArgs>? KeepAliveSucceeded;
279279

280280
/// <summary>
281281
/// Fetch the tunnel from the service if <see cref="ManagementClient"/> and <see cref="Tunnel"/> are not null.
@@ -370,15 +370,15 @@ protected virtual async Task<bool> OnRefreshingTunnelAccessTokenAsync(Cancellati
370370
/// </summary>
371371
protected virtual void OnKeepAliveFailed(int count)
372372
{
373-
KeepAliveFailed?.Invoke(this, new SshKeepAliveFailureEventArgs(count));
373+
KeepAliveFailed?.Invoke(this, new SshKeepAliveEventArgs(count));
374374
}
375375

376376
/// <summary>
377377
/// Event raised when a keep-alive message response is not received.
378378
/// </summary>
379379
protected virtual void OnKeepAliveSucceeded(int count)
380380
{
381-
KeepAliveSucceeded?.Invoke(this, new SshKeepAliveSuccessEventArgs(count));
381+
KeepAliveSucceeded?.Invoke(this, new SshKeepAliveEventArgs(count));
382382
}
383383

384384
/// <inheritdoc />

0 commit comments

Comments
 (0)