cherry-pick AOF fix (#1742)

Author: vazois

libs/host/Configuration/Options.cs

@@ -831,6 +831,12 @@ endpoint is IPEndPoint listenEp && clusterAnnounceEndpoint[0] is IPEndPoint anno
                     throw new Exception("SlowLogThreshold must be at least 100 microseconds.");
             }
 
+            if (!EnableAOF.GetValueOrDefault())
+            {
+                if (!string.IsNullOrEmpty(AofSizeLimit))
+                    throw new GarnetException("AofSizeLimit cannot be enforced with disabled AOF!");
+            }
+
             Func<INamedDeviceFactoryCreator> azureFactoryCreator = () =>
             {
                 if (!string.IsNullOrEmpty(AzureStorageConnectionString))

test/Garnet.test/GarnetServerConfigTests.cs

@@ -1312,5 +1312,24 @@ public void RevivificationFlagOrderingIndependence()
                 Assert.Throws<Exception>(() => options.GetServerOptions(), $"Should throw for args: {string.Join(" ", args)}");
             }
         }
+
+        [Test]
+        public void AofSizeLimitWithoutAofEnabled()
+        {
+            // Setting --aof-size-limit without --aof should throw
+            var args = new[] { "--aof-size-limit", "64m" };
+            var parseSuccessful = ServerSettingsManager.TryParseCommandLineArguments(args, out var options, out var invalidOptions, out _, out _, silentMode: true);
+            ClassicAssert.IsTrue(parseSuccessful);
+            ClassicAssert.AreEqual(0, invalidOptions.Count);
+            var ex = Assert.Throws<GarnetException>(() => options.GetServerOptions());
+            ClassicAssert.IsTrue(ex.Message.Contains("AofSizeLimit"));
+
+            // Setting --aof-size-limit with --aof enabled should succeed
+            args = ["--aof", "--aof-size-limit", "64m"];
+            parseSuccessful = ServerSettingsManager.TryParseCommandLineArguments(args, out options, out invalidOptions, out _, out _, silentMode: true);
+            ClassicAssert.IsTrue(parseSuccessful);
+            ClassicAssert.AreEqual(0, invalidOptions.Count);
+            Assert.DoesNotThrow(() => options.GetServerOptions());
+        }
     }
 }