Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chapter15: bugfixes and improvements for notebook-rag-vector-databases.ipynb #605

Open
bmerkle opened this issue Oct 4, 2024 · 1 comment
Assignees

Comments

@bmerkle
Copy link
Contributor

bmerkle commented Oct 4, 2024

Describe the bug
depending on @koreyspace feedback, this issue might be split into several issues.

there are a few problems in notebook-rag-vector-databases.ipynb
I have already prepared a PR and fixes for the issues below

  • !pip install should be %pip install

  • pip install azure-cosmos is missing the %

  • az cosmosdb create statement uses a wrong option -r. This should be -g

  • az cosmosedb list-keys is deprecated. This should be replaced with "keys list" option

  • all envrionment variables should be replaced with an .env file and code which reads them (based on dotenv)

  • data file names are invalid (data/frameworks.md?WT.mc_id=academic-105485-koreyst). The part after ? shall be deleted

  • code to append() the DataFrame is outdated and shall be updated to use concat() etc

  • Python notebook could be split in two parts
    -- part one: read training data, and create embeddings
    -- part two: the RAG part

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

Copy link

github-actions bot commented Oct 4, 2024

👋 Thanks for contributing @bmerkle! We will review the issue and get back to you soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants