Merge remote-tracking branch 'origin/main' into kasenlaskar/hyperv_module_add_and_fix

Author: kanchansenlaskar

.github/copilot-instructions.md

@@ -0,0 +1,148 @@
+# LISA Testing Guidelines for Pull Requests
+
+This document provides comprehensive guidelines for generating test suggestions for pull requests (PRs) in the LISA project. These guidelines ensure thorough validation while maintaining cost efficiency and testing relevance.
+
+## Overview
+
+When reviewing or creating PRs, follow these three key areas of testing guidance:
+
+1. **Test Case Selection** - Identify the essential test methods
+2. **Feature Impact Analysis** - Determine affected LISA features
+3. **Image Selection** - Choose appropriate Azure marketplace images
+
+## Copilot Instructions for Code Reviews
+
+**MANDATORY REQUIREMENT:** Every code review must include a test suggestion using the Quick Reference Template provided below. This is required for all pull request reviews to ensure consistent test coverage guidance.
+
+When reviewing any pull request, you must:
+
+1. **Always generate and present the test suggestion block** as part of your review
+2. **Use the exact Quick Reference Template format** (found at the bottom of this document) for copy-paste convenience
+3. **Include all three required components:**
+   - Essential integration/end-to-end test method names (using exact method names separated by `|`)
+   - Directly impacted LISA feature class names (using exact class names as they appear in codebase)
+   - Minimal set of Azure Marketplace images required for validation (using exact image strings from the provided list)
+
+This ensures every code review provides actionable, standardized test guidance that reviewers and contributors can immediately use for validation.
+
+## Test Case Selection Guidelines
+
+### Unit Tests
+- Unit tests are automatically included and should **not** be listed in test suggestions
+- Focus only on integration and end-to-end test recommendations
+
+### Key Test Cases
+- **Identify Essential Tests Only**: Select the minimal set of test cases that validate your specific changes
+- **Use Method Names**: Always specify the exact test method names, never include class names or file paths
+  - ✅ Correct: `verify_reboot_in_platform`
+  - ❌ Incorrect: `core.provisioning` or `TestProvisioning.verify_reboot_in_platform`
+- **Multiple Test Format**: When suggesting multiple tests, separate method names with a pipe (`|`) for easy copy-paste usage
+  - Example: `verify_reboot_in_platform|verify_stop_start_in_platform|verify_resize_operation`
+
+### Test Selection Strategy
+- If your change targets specific functionality, choose tests that directly exercise that functionality
+- If your change is broad or foundational, select representative tests that cover the most likely impact areas
+
+## LISA Features Impact Analysis
+
+### What are LISA Features?
+LISA Features are platform-specific capability classes that represent testable functionality. They serve as requirements for test cases and help identify testing scope.
+
+### Common LISA Features
+Examples include (but are not limited to):
+- `Gpu` - Graphics processing capabilities
+- `Nvme` - NVMe storage functionality
+- `StartStop` - VM start/stop operations
+- `Resize` - VM resizing capabilities
+- `NetworkInterface` - Network interface management
+- `SerialConsole` - Serial console access
+- `Hibernate` - VM hibernation features
+
+### Feature Selection Guidelines
+- List only features **directly impacted** by your changes
+- Use the exact feature class names as they appear in the codebase
+- Consider both primary and secondary impacts of your changes
+
+## Azure Marketplace Image Selection
+
+### Selection Principles
+- **Minimize Cost**: Select only the essential images needed to validate your changes
+- **Maximize Coverage**: Ensure selected images cover the key scenarios affected by your PR
+- **Use Exact Strings**: Always provide the complete image string exactly as listed below for direct copy-paste usage
+
+### When to Select Images
+- **OS-Specific Changes**: Choose images representing the affected operating systems
+- **Architecture Changes**: Include both x64 and ARM64 variants if relevant
+- **Generation Changes**: Consider both Gen1 and Gen2 images if applicable
+- **Distribution Changes**: Select specific Linux distributions if your change is distribution-sensitive
+
+### Available Azure Marketplace Images
+
+Copy the exact string for the images you need:
+
+#### Ubuntu Images
+- `canonical 0001-com-ubuntu-server-jammy 22_04-lts latest`
+- `canonical 0001-com-ubuntu-server-jammy 22_04-lts-arm64 latest`
+- `canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest`
+- `canonical ubuntu-24_04-lts server latest`
+- `canonical ubuntu-24_04-lts server-arm64 latest`
+- `canonical ubuntu-24_04-lts server-gen1 latest`
+
+#### Debian Images
+- `debian debian-11 11 latest`
+- `debian debian-11 11-gen2 latest`
+- `debian debian-12 12 latest`
+- `debian debian-12 12-arm64 latest`
+- `debian debian-12 12-gen2 latest`
+
+#### Azure Linux Images
+- `microsoftcblmariner azure-linux-3 azure-linux-3 latest`
+- `microsoftcblmariner azure-linux-3 azure-linux-3-arm64 latest`
+- `microsoftcblmariner azure-linux-3 azure-linux-3-gen2 latest`
+
+#### Oracle Linux Images
+- `oracle oracle-linux ol810-arm64-lvm-gen2 latest`
+- `oracle oracle-linux ol810-lvm latest`
+- `oracle oracle-linux ol810-lvm-gen2 latest`
+- `oracle oracle-linux ol94-arm64-lvm-gen2 latest`
+- `oracle oracle-linux ol94-lvm latest`
+- `oracle oracle-linux ol94-lvm-gen2 latest`
+
+#### Red Hat Enterprise Linux Images
+- `redhat rhel 8_10 latest`
+- `redhat rhel 810-gen2 latest`
+- `redhat rhel 9_5 latest`
+- `redhat rhel 95_gen2 latest`
+- `redhat rhel-arm64 9_5-arm64 latest`
+
+#### SUSE Linux Enterprise Server Images
+- `suse sles-12-sp5 gen1 latest`
+- `suse sles-12-sp5 gen2 latest`
+- `suse sles-15-sp6 gen1 latest`
+- `suse sles-15-sp6 gen2 latest`
+- `suse sles-15-sp6-arm64 gen2 latest`
+
+## Best Practices Summary
+
+1. **Be Specific**: Use exact method names, feature classes, and image strings
+2. **Be Minimal**: Select only what's necessary to validate your changes
+3. **Be Practical**: Format suggestions for easy copy-paste usage
+4. **Be Comprehensive**: Consider all three areas (tests, features, images) for complete coverage
+5. **Be Cost-Conscious**: Remember that each image selection has cost implications
+
+## Quick Reference Template
+
+When providing test suggestions, use this format:
+
+```
+**Key Test Cases:**
+verify_reboot_in_platform|verify_stop_start_in_platform|smoke_test
+
+**Impacted LISA Features:**
+FeatureName1, FeatureName2, FeatureName3
+
+**Tested Azure Marketplace Images:**
+- exact image string 1
+- exact image string 2
+- exact image string 3
+```

docs/run_test/platform.rst

@@ -141,13 +141,14 @@ deployment.
       ...
       admin_private_key_file: "<path of private key file>"
       azure:
-         virtual_network_resource_group: $(vnet_resource_group)
-         virtual_network_name: $(vnet_name)
-         subnet_prefix: $(subnet_name)
+         virtual_network_resource_group: $(virtual_network_resource_group)
+         virtual_network_name: $(virtual_network_name)
+         subnet_prefix: $(subnet_prefix)
          use_public_address: "<true or false>"
          create_public_address: "<true or false>"
          use_ipv6: "<true or false>"
          enable_vm_nat: "<true or false>"
+         source_address_prefixes: $(source_address_prefixes)
       requirement:
          ...
          ignored_capability:
@@ -205,6 +206,22 @@ deployment.
   subnet to access the internet. The default value is `false`, it means that
   the DefaultOutboundAccess property of the subnet will be set to "False".
   This means that the VMs in the subnet cannot access the internet.
+* **source_address_prefixes**. Specify source IP address ranges that are 
+  allowed to access the VMs through network security group rules. If not
+  provided, your current public IP address will be automatically detected and 
+  used. You can specify multiple IP ranges using either comma-separated string
+  format or YAML list format. Examples:
+  
+  .. code:: bash
+  
+     # Single IP range (string format)
+     lisa -r ./microsoft/runbook/azure.yml -v "source_address_prefixes:192.168.1.0/24"
+     
+     # Multiple IP ranges (comma-separated string format)
+     lisa -r ./microsoft/runbook/azure.yml -v "source_address_prefixes:192.168.1.0/24,10.0.0.0/8"
+     
+     # List format
+     lisa -r ./microsoft/runbook/azure.yml -v "source_address_prefixes:['192.168.1.0/24','10.0.0.0/8']"
 * **ignored_capability**. Specify feature names which will be ignored in 
   test requirement. You can find the feature name from its name method in source code.
   For example, IsolatedResource feature's name defined in ``lisa/features/isolated_resource.py`` as below:

docs/run_test/runbook.rst

@@ -64,6 +64,12 @@ Runbook Reference
          -  `path <#path-2>`__
          -  `auto_open <#auto-open>`__
 
+      -  `junit <#junit>`__
+
+         -  `path <#path-3>`__
+         -  `include_subtest <#include-subtest>`__
+         -  `append_message_id <#append-message-id>`__
+
    -  `environment <#environment>`__
 
       -  `retry <#retry>`__
@@ -668,6 +674,50 @@ Example of html notifier:
        path: ./lisa.html
        auto_open: true
 
+junit
+^^^^^
+
+Output test results in JUnit XML format. The generated XML file can be used
+for integration with CI/CD systems, dashboards, and other tools that consume
+JUnit test results.
+
+.. _path-3:
+
+path
+''''
+
+type: str, optional, default: lisa.junit.xml
+
+Specify the output file name and path for the JUnit XML report.
+
+include_subtest
+'''''''''''''''
+
+type: bool, optional, default: True
+
+When set to True, subtests will be included as separate test cases in the
+JUnit XML output. When set to False, only main test cases are included.
+
+append_message_id
+'''''''''''''''''
+
+type: bool, optional, default: True
+
+When set to True, the message ID will be appended to test case names in the
+format "test_name (message_id)". This is useful when using combinators to
+distinguish multiple test runs of the same test case. When set to False,
+only the base test case name is used.
+
+Example of junit notifier:
+
+.. code:: yaml
+
+   notifier:
+     - type: junit
+       path: ./results.xml
+       include_subtest: true
+       append_message_id: false
+
 environment
 ~~~~~~~~~~~
 

docs/run_test/transformers.rst

@@ -244,6 +244,10 @@ Usage
   transformer:
     - type: azure_deploy
       resource_group_name: rg_name
+      deploy: true
+      source_address_prefixes: 
+        - "192.168.1.0/24"
+        - "10.0.0.0/8"
       requirement:
         azure:
           marketplace: image_name
@@ -268,7 +272,7 @@ resource_group_name
 
 type: string
 
-Name of the resource group in which VM should be deployed. Creates a new RG if not specified.
+Name of the resource group in which VM should be deployed. Creates a new RG if not specified. When not provided, the platform configuration will be used for the transformer. When the VM of transformer has different resource group requirements, it can be overwritten here. This only works for new fresh deployment - if the resource group already exists, it does nothing.
 
 requirement
 ^^^^^^^^^^^
@@ -288,6 +292,12 @@ type: bool | Default: true
 
 Whether to create a new deployment. If true, creates a new VM deployment. If false, uses existing VMs in the specified resource_group_name.
 
+source_address_prefixes
+^^^^^^^^^^^^^^^^^^^^^^^
+type: Optional[Union[str, List[str]]] | Default: None
+
+Source address prefixes for network security rules. Can be a single string, a comma-separated string, or a list of strings. When not specified, defaults to the current public IP address for security. When not provided, the platform configuration will be used for the transformer. When the VM of transformer has different network infrastructure requirements, it can be overwritten here.
+
 
 Use Delete Transformer
 ~~~~~~~~~~~~~~~~~~~~~~

examples/__init__.py

@@ -38,12 +38,14 @@ def read_with_filter(
         force_run: bool = False,
         sudo: bool = False,
         invert_match: bool = False,
+        ignore_error: bool = False,
     ) -> str:
         # Combining cat with grep
         if invert_match:
             params = f'{file} | grep -v "{grep_string}"'
         else:
             params = f'{file} | grep "{grep_string}"'
         result = self.run(params, force_run=force_run, sudo=sudo, shell=True)
-        result.assert_exit_code(message=f"Error : {result.stdout}")
+        if not ignore_error:
+            result.assert_exit_code(message=f"Error : {result.stdout}")
         return result.stdout

lisa/base_tools/cat.py

@@ -6,6 +6,8 @@
 from typing import Optional, Type
 
 from lisa.executable import ExecutableResult, Tool
+from lisa.tools.dmesg import Dmesg
+from lisa.tools.journalctl import Journalctl
 from lisa.tools.powershell import PowerShell
 from lisa.util import (
     LisaException,
@@ -49,6 +51,9 @@ def _check_exists(self) -> bool:
     def restart_service(self, name: str, ignore_exit_code: int = 0) -> None:
         self._internal_tool.restart_service(name, ignore_exit_code)  # type: ignore
 
+    def start_service(self, name: str, ignore_exit_code: int = 0) -> None:
+        self._internal_tool.start_service(name, ignore_exit_code)  # type: ignore
+
     def stop_service(self, name: str) -> None:
         self._internal_tool.stop_service(name)  # type: ignore
 
@@ -135,6 +140,14 @@ def stop_service(self, name: str) -> None:
 
     def restart_service(self, name: str, ignore_exit_code: int = 0) -> None:
         cmd_result = self.run(f"restart {name}", shell=True, sudo=True, force_run=True)
+        if cmd_result.exit_code != 0 and cmd_result.exit_code != ignore_exit_code:
+            self._collect_logs(name)
+        _check_error_codes(cmd_result, ignore_exit_code)
+
+    def start_service(self, name: str, ignore_exit_code: int = 0) -> None:
+        cmd_result = self.run(f"start {name}", shell=True, sudo=True, force_run=True)
+        if cmd_result.exit_code != 0 and cmd_result.exit_code != ignore_exit_code:
+            self._collect_logs(name)
         _check_error_codes(cmd_result, ignore_exit_code)
 
     def enable_service(self, name: str) -> None:
@@ -209,6 +222,44 @@ def _check_service_running(self, name: str) -> bool:
             or "not-found" in cmd_result.stdout
         ) and 0 == cmd_result.exit_code
 
+    def _collect_logs(self, service_name: str) -> None:
+        self._log.info(f"Collecting logs for service '{service_name}'.")
+
+        # Get detailed status from systemctl status
+        status_cmd = f"status {service_name} --no-pager -n 100"
+        try:
+            _ = self.run(status_cmd, shell=True, sudo=True, force_run=True)
+        except Exception as e_status:
+            self._log.info(f"Failed to get status for {service_name}: {e_status}")
+
+        try:
+            journal_tail_lines = 50
+            journalctl_tool = self.node.tools[Journalctl]
+            journal_output = journalctl_tool.logs_for_unit(unit_name=service_name)
+            journal_lines = journal_output.splitlines()
+            tail_lines = "\n".join(journal_lines[-journal_tail_lines:])
+            self._log.info(
+                f"Last {journal_tail_lines} journal logs for unit '{service_name}':\n"
+                f"{tail_lines}"
+            )
+        except Exception as e_journal:
+            self._log.info(
+                f"Could not retrieve or process journal logs for {service_name}: "
+                f"{e_journal}"
+            )
+
+        try:
+            dmesg_tail_lines = 25
+            dmesg = self.node.tools[Dmesg]
+            dmesg_out = dmesg.get_output(
+                force_run=True, no_debug_log=True, tail_lines=dmesg_tail_lines
+            )
+            self._log.info(
+                f"Last {dmesg_tail_lines} lines of dmesg output:\n{dmesg_out}"
+            )
+        except Exception as e_dmesg:
+            self._log.info(f"Could not retrieve dmesg output: {e_dmesg}")
+
 
 def _check_error_codes(cmd_result: ExecutableResult, error_code: int = 0) -> None:
     cmd_result.assert_exit_code(expected_exit_code=[0, error_code])