Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconnection issue with lockTimeout configured #2438

Open
Jeffery-Wasty opened this issue Jun 4, 2024 · 4 comments · May be fixed by #2517
Open

Reconnection issue with lockTimeout configured #2438

Jeffery-Wasty opened this issue Jun 4, 2024 · 4 comments · May be fixed by #2517
Assignees

Comments

@Jeffery-Wasty
Copy link
Member

As reported in #2353, when a reconnection is triggered while lockTimeout is configured this can lead to a case where the TDSCommand iCounter is null. In #2253 this created a NullPointerException which was subsquently fixed for 12.7.0, but the underlying reconnection issue remains. It is thought this is related to our other retry/reconnection issues and so work needs to conclude on rewriting the underlying retry logic first before tackling an edge case such as this one.

@Jeffery-Wasty
Copy link
Member Author

We will provide updates on the reconnection issue in this GitHub thread.

@HeinzHuberRsg
Copy link

Our connection settings (from openliberty):

        <properties.microsoft.sqlserver
                serverName="${DATASOURCE_DRBQUERJOURNAL_HOSTNAME}"
                portNumber="${DATASOURCE_DRBQUERJOURNAL_PORT}"
                databaseName="${DATASOURCE_DRBQUERJOURNAL_DATABASE}"
                user="${DATASOURCE_DRBQUERJOURNAL_USERNAME}"
                password="${DATASOURCE_DRBQUERJOURNAL_PASSWORD}"
                encrypt="true"
                applicationIntent="readwrite"
                trustServerCertificate="true"
                multiSubnetFailover="true"
                transparentNetworkIPResolution="true"
                lockTimeout="240s"
                serverPreparedStatementDiscardThreshold="10"
                disableStatementPooling="false"
                statementPoolingCacheSize="10"
        />

@Jeffery-Wasty
Copy link
Member Author

Hi @HeinzHuberRsg,

Do you have the repro mentioned in #2353?

image

I'm not able to see the above referenced case (I'm guessing its closed). I am working on the reconnection changes at the moment, but am not able to reproduce the above issue.

@Jeffery-Wasty
Copy link
Member Author

Still not able to repro this, but a solution would be adding the error to the list of custom list of errors to retry on, aka Configurable Retry Logic. I'll post a link to the PR and Wiki link (both once created) for more information.

@Jeffery-Wasty Jeffery-Wasty linked a pull request Sep 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

2 participants