[Rebase & FF] Making StandaloneMmIplPei compatible with supervisor #1583
+10
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuqin12
commented
Dec 8, 2025
StandaloneMmPkg/Drivers/MmCommunicationDxe/MmCommunicationDxe.c
Outdated
Show resolved
Hide resolved
| // // | ||
| // // Build ACPI variable HOB | ||
| // // | ||
| // HobLength = GetRemainingHobSize (*FoundationHobSize, UsedSize); |
Contributor
Author
There was a problem hiding this comment.
This will be guarded by the s3 PCD.
| HobLength = GetRemainingHobSize (*FoundationHobSize, UsedSize); | ||
| MmIplBuildResourceHobForUnblockedRegion (FoundationHobList + UsedSize, &HobLength); | ||
| // MmIplBuildResourceHobForUnblockedRegion (FoundationHobList + UsedSize, &HobLength); | ||
| MmIplCopyGuidHob (FoundationHobList + UsedSize, &HobLength, &gMmUnblockRegionHobGuid, TRUE); |
Contributor
Author
There was a problem hiding this comment.
We will rename the GUID...
Contributor
Author
There was a problem hiding this comment.
A different PR is created here: microsoft/mu_feature_mm_supv#583
| Size = sizeof (CommunicateHeader); | ||
| Status = Communicate (NULL, &CommunicateHeader, &Size); | ||
| ASSERT_EFI_ERROR (Status); | ||
| // ASSERT_EFI_ERROR (Status); |
Contributor
Author
There was a problem hiding this comment.
Not sure what to do with this.
Contributor
Author
There was a problem hiding this comment.
This is PRed as is. Will see if others have different opinions.
The current module checks the value of gEfiAcpiVariableGuid hobs and could assert if there is no such hob available. However, these hobs are only available if a platform elects to support S3. Thus this change moves the hob copy logic behind a PCD check to prevent unnecessary asserts. Signed-off-by: Kun Qin <[email protected]>
The current module checks the return status of MmIplDispatchMmDrivers. Any failure would cause the system to assert. However, this should not be deemed as fatal since the result could be entirely implementation defined on the Standalone MM core side. This change loosens the check and not to do asserts on dispatcher requests. Signed-off-by: Kun Qin <[email protected]>
kuqin12
changed the title
kuqin12
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current implementation of the
StandaloneMmIplPeihas a few design differences compared to MM supervisor.This will introduce more maintenance burden as we move to the next phase of MM supervisor.
This change is made to try to converge the 2 designs, at least from the perspective of IPL, in order to use the IPL as is and still conform to the MM supervisor modelity.
For details on how to complete these options and their meaning refer to CONTRIBUTING.md.
How This Was Tested
This is tested on QEMU Q35 and booted to UEFI shell.
Integration Instructions
N/A