sample xaml module integrated with sample-app-fabric #15368
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| EXPORTS | ||
| DllCanUnloadNow = WINRT_CanUnloadNow PRIVATE | ||
| DllGetActivationFactory = WINRT_GetActivationFactory PRIVATE | ||
| RegisterXamlHostComponentView |
Contributor
There was a problem hiding this comment.
Why are we adding RegisterXamlHostComponentView as a part of DLL exports. Xaml hosting is part of same DLL right?
Contributor
Author
There was a problem hiding this comment.
I think we can get rid of this. Let me check how to that is on me. But this should not block you.
| import * as React from 'react'; | ||
| import RawCalendarView from './CalendarViewNativeComponent'; | ||
|
|
||
| import XamlHost from 'react-native-windows/Libraries/Components/Xaml/XamlHost'; |
Contributor
There was a problem hiding this comment.
Are we not exporting XamlHost tag from react-native-windows? Like import XamlHost from "react-native-windows"
instead of 'react-native-windows/Libraries/Components/Xaml/XamlHost'
Contributor
Author
There was a problem hiding this comment.
This is a task that needs to be fixed: #15317
| @@ -0,0 +1,2 @@ | |||
| import { CalendarView, RawCalendarView} from './CalendarView'; | |||
| export { CalendarView, RawCalendarView }; | |||
Contributor
There was a problem hiding this comment.
These seem duplicate we are already exporting { CalendarView, RawCalendarView } from CalendarView.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Erase all that don't apply.
Why
What is the motivation for this change? Add a few sentences describing the context and overall goals of the pull request's commits.
Resolves [Add Relevant Issue Here]
What
What changes were made to the codebase to solve the bug, add the functionality, etc. that you specified above.
Screenshots
Add any relevant screen captures here from before or after your changes.
Testing
If you added tests that prove your changes are effective or that your feature works, add a few sentences here detailing the added test scenarios.
Optional: Describe the tests that you ran locally to verify your changes.
Changelog
Should this change be included in the release notes: indicate yes or no
Add a brief summary of the change to use in the release notes for the next release.
Microsoft Reviewers: Open in CodeFlow