Fix focusFollowMouse (#15420)

zadjii-msft · DHowett · commit 20c1d563fc5a · 2023-05-26T10:56:54.000-07:00
Because this looks like it's entirely broken in `main`, and possibly in 1.17(?) We didn't take a strong ref to the coroutine parameter. As to be expected, that explodes. Closes #15412 (cherry picked from commit 6775300) Service-Card-Id: 89311372 Service-Version: 1.17
diff --git a/src/cascadia/TerminalApp/TerminalTab.cpp b/src/cascadia/TerminalApp/TerminalTab.cpp
@@ -946,7 +946,7 @@ namespace winrt::TerminalApp::implementation
             }
         });
 
-        events.focusToken = control.FocusFollowMouseRequested([dispatcher, weakThis](auto&& sender, auto&&) -> winrt::fire_and_forget {
+        events.focusToken = control.FocusFollowMouseRequested([dispatcher, weakThis](auto sender, auto) -> winrt::fire_and_forget {
             co_await wil::resume_foreground(dispatcher);
             if (const auto tab{ weakThis.get() })
             {

Original file line number	Diff line number	Diff line change
`@@ -946,7 +946,7 @@ namespace winrt::TerminalApp::implementation`
`946`	`946`	`}`
`947`	`947`	`});`
`948`	`948`
`949`		`- events.focusToken = control.FocusFollowMouseRequested([dispatcher, weakThis](auto&& sender, auto&&) -> winrt::fire_and_forget {`
	`949`	`+ events.focusToken = control.FocusFollowMouseRequested([dispatcher, weakThis](auto sender, auto) -> winrt::fire_and_forget {`
`950`	`950`	`co_await wil::resume_foreground(dispatcher);`
`951`	`951`	`if (const auto tab{ weakThis.get() })`
`952`	`952`	`{`