Ignore OSC 7 notifications if host name is not terminal host?

[krobelus]

I've not read through all of #8214 and #3158,
but in the recently added support for OSC 7, it looks like when we receive file://someremoteserver/tmp, we set the working directory for new tabs to /tmp.
This is wrong, because new tabs are opened on the local system.
We should check that it matches (the equivalent of) gethostname() and some other cases, see foot source code for example.
cc @lhecker (I wanted to comment on the commit directly but can't right now for some reason (at least when using the Web UI)).

See also:

• https://codeberg.org/dnkl/foot/commit/7466e87a
• https://invent.kde.org/utilities/konsole/-/merge_requests/1049/diffs
• https://www.zsh.org/mla/workers/2026/msg00003.html

[krobelus]

Oh the problem is already mentioned (look for "hostname" in #8214 or 4ce79d7).
I guess WSL makes it harder.. but distros could announce their hostname to the terminal when the terminal gets attached,
and then the terminal can ignore OSC 7 notifications with different hostnames.
I assume the working directory is used for "Duplicate tab"; not sure if it's used for anything else?

[lhecker]

but in the recently added support for OSC 7, it looks like when we receive file://someremoteserver/tmp, we set the working directory for new tabs to /tmp.

PathCreateFromUrlW is actually a pretty neat API. It translates localhost URIs and those with a missing domain (e.g. file:///C:/foo/bar) automatically to a classic Win32 path (C:\foo\bar, etc.). But URIs with a custom domain get translated to UNC path. So, file://someremoteserver/tmp actually results in \\someremoteserver\tmp (an SMB share or whatever). I consider this to be pretty neat because it means a native Windows shell can use OSC 7 to work on remote SMB directories!

For this reason, I'm hesitant to ignore non-local hostnames. It breaks working on SMB shares.

To "fix" the behavior for WSL (= domain name doesn't map to a UNC path), I have decided to put a simple path-exists check before any places that make use of the OSC 7 path. This means that duplicate tab of a fish shell via WSL doesn't work. But I suppose that's alright for an initial implementation.

I concur that we need to do something about the behavior for WSL. We already have provisions in place to intelligently turn Win32 paths to UNIX paths on paste, so I think doing the same for CWD paths should be trivial.

[DHowett]

I wanted to comment on the commit directly but can't right now for some reason (at least when using the Web UI)

Oh, yeah, GitHub finally allowed maintainers to stop people from commenting on commits. Commenting on a pull request is more than sufficient--as is filing an issue as you have done!

[krobelus]

I have decided to put a simple path-exists check before any places that make use of the OSC 7 path

I see, I didn't realize that because expected this check to be done before we'd store the OSC 7 path (so we wouldn't even store "non-existant" paths from WSL etc).
So I guess the new OSC 7 support won't cause obvious breakage, and we can close this issue?
(or keep it for tracking support for WSL?).