From 53315e0bb2bc8c3316704b27a97bbaaa7b3c1b23 Mon Sep 17 00:00:00 2001
From: Youssef Victor <youssefvictor00@gmail.com>
Date: Mon, 16 Dec 2024 10:24:45 +0100
Subject: [PATCH] Enable CS1591: Missing XML comment for publicly visible type
 or member

---
 Directory.Build.props | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/Directory.Build.props b/Directory.Build.props
index 25e725ef65..2bd5603288 100644
--- a/Directory.Build.props
+++ b/Directory.Build.props
@@ -1,4 +1,9 @@
 <Project>
+  <PropertyGroup>
+    <!-- This needs to happen before importing Arcade props. -->
+    <!-- Otherwise, Arcade would have already included 1591 in NoWarn -->
+    <SkipArcadeNoWarnCS1591>true</SkipArcadeNoWarnCS1591>
+  </PropertyGroup>
 
   <Import Project="Sdk.props" Sdk="Microsoft.DotNet.Arcade.Sdk" />
   <Import Project="$(RepositoryEngineeringDir)Analyzers.props" />
@@ -18,9 +23,8 @@
         not report warnings for missing comments.
 
         CS1573: Parameter 'parameter' has no matching param tag in the XML comment for 'parameter' (but other parameters do)
-        CS1591: Missing XML comment for publicly visible type or member 'Type_or_Member'
       -->
-    <NoWarn>$(NoWarn),1573,1591</NoWarn>
+    <NoWarn>$(NoWarn),1573</NoWarn>
   </PropertyGroup>
 
   <!-- The TFMs to build and test against. -->