-
Notifications
You must be signed in to change notification settings - Fork 290
Add samples build verification to CI pipeline #6802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Evangelink <[email protected]>
Co-authored-by: Evangelink <[email protected]>
Co-authored-by: Evangelink <[email protected]>
Evangelink
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also make the full powershell building all examples a script inside eng folder so that it can be run locally by devs
|
@copilot please handle comments |
…, extract script Co-authored-by: Evangelink <[email protected]>
Created .\eng\build-samples.ps1 -Configuration ReleaseThe script iterates through all sample solutions in samples/public and provides a summary of results. |
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
@copilot pipeline seems to be broken: Do not update |
…sing Co-authored-by: Evangelink <[email protected]>
samples/public/mstest-runner/runner_vs_vstest/RunnerVsVSTest.sln
Outdated
Show resolved
Hide resolved
Co-authored-by: Evangelink <[email protected]>
Co-authored-by: Evangelink <[email protected]>
Co-authored-by: Evangelink <[email protected]>
Added CI pipeline job to build and verify public samples, with optimizations for performance and code quality improvements based on review feedback.
Changes Made
✅ Added WindowsSamples CI Job
azure-pipelines.ymlto build samples on Windows (Release and Debug configurations)✅ Created
eng/build-samples.ps1Scriptsamples/public✅ Added Solution File
samples/public/mstest-runner/Simple1/Simple1.sln✅ Simplified Path Handling (Review feedback from @nohwnd)
Join-Pathto simple string interpolation with forward slashes$samplesFolder = "$repoRoot/samples/public"instead of nested Join-Path calls. "$PSScriptRoot/common/tools.ps1"using forward slashes$dotnetPath = "$dotnetRoot/dotnet.exe"using forward slashes✅ Improved Parameter Type (Review feedback from @nohwnd)
[bool]$TreatWarningsAsErrors = $falseto[switch]$TreatWarningsAsErrors-TreatWarningsAsErrorsflag✅ Restored MSTestRunnerWinUI.sln (Comment from @Evangelink)
✅ Enabled TreatWarningsAsErrors (Comment from @Youssef1313 / @Evangelink)
-TreatWarningsAsErrorsflag to CI pipeline arguments for stricter validationSolutions Built in CI (11 total)
Note: The
runner_vs_vstestfolder contains performance comparison projects (1K, 10K, 100K tests) that are not included in CI builds as they don't have a solution file and are intended for local performance testing only.Benefits
.\eng\build-samples.ps1Testing
PowerShell syntax validated ✓
Azure Pipelines YAML validated ✓
Script logic tested with various configurations ✓
Fixes Public samples are not built in CI #6695
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.