Fix canHaveLiteralInitializer misport (#2219)

Author: jakebailey

internal/transformers/declarations/util.go

@@ -14,7 +14,7 @@ func canHaveLiteralInitializer(host DeclarationEmitHost, node *ast.Node) bool {
 	switch node.Kind {
 	case ast.KindPropertyDeclaration,
 		ast.KindPropertySignature:
-		return host.GetEffectiveDeclarationFlags(node, ast.ModifierFlagsPrivate) != 0
+		return host.GetEffectiveDeclarationFlags(node, ast.ModifierFlagsPrivate) == 0
 	case ast.KindParameter,
 		ast.KindVariableDeclaration:
 		return true

testdata/baselines/reference/submodule/compiler/computedEnumTypeWidening.js

@@ -178,7 +178,7 @@ declare let v2: E.B;
 declare class C {
     p1: E;
     p2: E.B;
-    readonly p3: E;
+    readonly p3 = E.B;
     readonly p4: E.B;
 }
 declare enum MyEnum {

testdata/baselines/reference/submodule/compiler/computedEnumTypeWidening.js.diff

@@ -35,13 +35,4 @@
 +    p4 = E.B;
  }
  // Repro from #52531
- var MyEnum;
-@@= skipped -45, +43 lines =@@
- declare class C {
-     p1: E;
-     p2: E.B;
--    readonly p3 = E.B;
-+    readonly p3: E;
-     readonly p4: E.B;
- }
- declare enum MyEnum {
+ var MyEnum;

testdata/baselines/reference/submodule/compiler/declarationEmitConstantNoWidening.js

@@ -20,5 +20,5 @@ exports.Bar = Bar;
 //// [declarationEmitConstantNoWidening.d.ts]
 export declare const FOO = "FOO";
 export declare class Bar {
-    readonly type: string;
+    readonly type = "FOO";
 }

testdata/baselines/reference/submodule/compiler/declarationEmitConstantNoWidening.js.diff

@@ -10,11 +10,3 @@
 +    type = exports.FOO; // Should be widening literal "FOO" - so either `typeof "FOO"` or = "FOO"
  }
  exports.Bar = Bar;
-
-@@= skipped -10, +8 lines =@@
- //// [declarationEmitConstantNoWidening.d.ts]
- export declare const FOO = "FOO";
- export declare class Bar {
--    readonly type = "FOO";
-+    readonly type: string;
- }

testdata/baselines/reference/submodule/compiler/declarationEmitEnumReadonlyProperty.js

@@ -30,6 +30,6 @@ declare enum E {
     B = "b"
 }
 declare class C {
-    readonly type: E;
+    readonly type = E.A;
 }
 declare let x: E.A;

testdata/baselines/reference/submodule/compiler/declarationEmitEnumReadonlyProperty.js.diff

@@ -10,12 +10,3 @@
 +    type = E.A;
  }
  let x = new C().type;
-
-@@= skipped -13, +11 lines =@@
-     B = "b"
- }
- declare class C {
--    readonly type = E.A;
-+    readonly type: E;
- }
- declare let x: E.A;

testdata/baselines/reference/submodule/compiler/declarationEmitPrivateReadonlyLiterals.js

@@ -20,8 +20,8 @@ class Foo {
 
 //// [declarationEmitPrivateReadonlyLiterals.d.ts]
 declare class Foo {
-    private static readonly A = "a";
-    private readonly B = "b";
-    private static readonly C = 42;
-    private readonly D = 42;
+    private static readonly A;
+    private readonly B;
+    private static readonly C;
+    private readonly D;
 }

testdata/baselines/reference/submodule/compiler/declarationEmitPrivateReadonlyLiterals.js.diff

@@ -17,14 +17,4 @@
 -Foo.C = 42;
 
 
- //// [declarationEmitPrivateReadonlyLiterals.d.ts]
- declare class Foo {
--    private static readonly A;
--    private readonly B;
--    private static readonly C;
--    private readonly D;
-+    private static readonly A = "a";
-+    private readonly B = "b";
-+    private static readonly C = 42;
-+    private readonly D = 42;
- }
+ //// [declarationEmitPrivateReadonlyLiterals.d.ts]

testdata/baselines/reference/submodule/compiler/initializerWithThisPropertyAccess.js

@@ -83,9 +83,9 @@ declare class C {
 }
 declare class Foo {
     private bar;
-    readonly barProp: boolean;
+    readonly barProp = false;
     constructor();
 }
 declare class Bar {
-    readonly prop: boolean;
+    readonly prop = false;
 }