New vscode extension version 0723 -> 0725 crashes on start and is unusable

[lukpsaxo]

Stack trace

Info 38   [12:57:44.215] Starting updateGraph: Project: c:/Projects/xyz/xyz/src/frontend/tsconfig.json
Info 39   [12:57:44.259] Program 1 used 3 checker(s)
Info 40   [12:57:44.805] Different program with same set of root files
Info 41   [12:57:45.595] createGlobMapper took 111.1395ms to create 10 globs for 152020 failed lookups
Info 42   [12:57:45.597] c:/Projects/xyz/xyz/src/frontend/tsconfig.json:: failed lookup watches unwatch watcher-2
Info 43   [12:57:45.598] c:/Projects/xyz/xyz/src/frontend/tsconfig.json:: failed lookup watches updated watcher-7:
	C:/Projects/xyz/xyz/node_modules/**/*.{js,jsx,mjs,cjs,ts,tsx,mts,cts,json}
	C:/Projects/xyz/xyz/src/**/*.{js,jsx,mjs,cjs,ts,tsx,mts,cts,json}
	C:/Projects/xyz/xyz/tools/**/*.{js,jsx,mjs,cjs,ts,tsx,mts,cts,json}
	C:/Projects/xyz/node_modules/**/*.{js,jsx,mjs,cjs,ts,tsx,mts,cts,json}
	C:/Projects/lodash-es/*.{js,jsx,mjs,cjs,ts,tsx,mts,cts,json}
	C:/Projects/node_modules/**/*.{js,jsx,mjs,cjs,ts,tsx,mts,cts,json}
	c:/Projects/xyz/xyz/node_modules/**/*.{js,jsx,mjs,cjs,ts,tsx,mts,cts,json}
	c:/Projects/xyz/xyz/src/**/*.{js,jsx,mjs,cjs,ts,tsx,mts,cts,json}
	c:/Projects/xyz/node_modules/**/*.{js,jsx,mjs,cjs,ts,tsx,mts,cts,json}
	c:/Projects/node_modules/**/*.{js,jsx,mjs,cjs,ts,tsx,mts,cts,json}
-----------------------------------------------
Info 44   [12:57:45.599] createGlobMapper took 555µs to create 5 globs for 340 failed lookups
Info 45   [12:57:45.599] Finishing updateGraph: Project: c:/Projects/xyz/xyz/src/frontend/tsconfig.json version: 1 in 1.3835526s
Info 46   [12:57:45.599] Starting updateGraph: Project: c:/Projects/xyz/xyz/src/frontend/tsconfig.json
Info 47   [12:57:45.621] Program 2 used 3 checker(s)
Info 48   [12:57:46.124] Different program with same set of root files
Info 49   [12:57:46.900] createGlobMapper took 178.8039ms to create 10 globs for 152020 failed lookups
Info 50   [12:57:46.900] createGlobMapper took 0s to create 5 globs for 340 failed lookups
Info 51   [12:57:46.900] Finishing updateGraph: Project: c:/Projects/xyz/xyz/src/frontend/tsconfig.json version: 2 in 1.3016149s
Info 52   [12:57:46.921] checkerpool: Checker for request 19 was canceled, disposing it
Info 53   [12:57:46.937] checkerpool: Checker for request 19 was canceled, disposing it
[Error - 12:57:46 PM] Request textDocument/diagnostic failed.
  Message: context canceled
  Code: -32603 
[Error - 12:57:46 PM] Document pull failed for text document file:///c%3A/Projects/xyz/xyz/src/frontend/models/regionalSettings/effects.spec.ts
  Message: context canceled
  Code: -32603 

Steps to reproduce

1. I updated my extension 23 -> 25
2. As soon as the currently open files are checked, and I make an edit to try and fix a ts error it crashes

3. Now ts is stuck - edits don't update the errors in text files, I have to restart the extension

Restarting causes a panic:

panic handling request shutdown interface conversion: interface is nil, not interface {} goroutine 433409 [running]:
runtime/debug.Stack()
	runtime/debug/stack.go:26 +0x5e
github.com/microsoft/typescript-go/internal/lsp.(*Server).dispatchLoop.func1.1()
	github.com/microsoft/typescript-go/internal/lsp/server.go:361 +0x5d
panic({0xa35da0?, 0xc0cb13c060?})
	runtime/panic.go:792 +0x132
github.com/microsoft/typescript-go/internal/lsp.init.func1.registerRequestHandler[...].3({0xd4a7f0?, 0xc068368000?}, 0x8?)
	github.com/microsoft/typescript-go/internal/lsp/server.go:522 +0xc8
github.com/microsoft/typescript-go/internal/lsp.(*Server).handleRequestOrNotification(0xc00019aa20, {0xd4a7f0, 0xc068368000}, 0xc0430a67e0)
	github.com/microsoft/typescript-go/internal/lsp/server.go:467 +0x10d
github.com/microsoft/typescript-go/internal/lsp.(*Server).dispatchLoop.func1()
	github.com/microsoft/typescript-go/internal/lsp/server.go:374 +0x75
created by github.com/microsoft/typescript-go/internal/lsp.(*Server).dispatchLoop in goroutine 22
	github.com/microsoft/typescript-go/internal/lsp/server.go:392 +0x4d2

[Error - 1:05:00 PM] Stopping server failed
  Message: InternalError: panic handling request shutdown: interface conversion: interface is nil, not interface {}
  Code: -32603 
[Error - 1:05:02 PM] Server process exited with code 1.

[jakebailey]

I probably broke all of this in #1441.

[lukeapage]

Note that after some time it stopped crashing so it’s not every time - just the first 3 edits I made after upgrading ..