Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute Test-CadlRanch with filter argument passed in CI when the file is modified in a PR #5614

Open
JoshLove-msft opened this issue Jan 15, 2025 · 2 comments
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp

Comments

@JoshLove-msft
Copy link
Contributor

JoshLove-msft commented Jan 15, 2025

If the file is modified in a PR, we should execute TestCadlRanch with "*" passed as the filter argument so that we are confident that the filter still works. Note, this should not be run in general as it would result in much slower CI times.

@JoshLove-msft JoshLove-msft added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Jan 15, 2025
@JoshLove-msft
Copy link
Contributor Author

Would need to also validate that tests actually run when passing "*".

@JoshLove-msft
Copy link
Contributor Author

JoshLove-msft commented Jan 15, 2025

One potential approach would be to map the filter to csprojs so that instead of invoking dotnet test with a namespace filter, we would pass the project argument. If this somehow got messed up, then dotnet test would return an error. We would still need CI to execute Test-CadlRanch. If we can somehow consolidate Get-Coverage and Test-CadlRanch such that Get-Coverage calls into Test-CadlRanch, then that would be a way of avoiding the extra CI check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Development

No branches or pull requests

1 participant