Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler/Emitter behavior consistency and improvement #5660

Open
7 tasks
allenjzhang opened this issue Jan 17, 2025 · 0 comments
Open
7 tasks

Compiler/Emitter behavior consistency and improvement #5660

allenjzhang opened this issue Jan 17, 2025 · 0 comments
Assignees

Comments

@allenjzhang
Copy link
Member

allenjzhang commented Jan 17, 2025

Compiler improvements:

  • Display emitters being invoked. This is helpful when there are multiple emitters, users will be able to see the progress.
  • When multiple emitters run, if one emitter fails, currently compiler skip the rest. We should decide whether we want to change the behavior to run all. If not, minimally should display message telling user we have skipped the rest of xxx emitters.
  • When crash happens, write out detailed log including callstack in a temp file instead of showing on console

Consistent behavior among emitters

  • Currently C# directly write out to console on files generated while other emitters writes nothing. They should be consistent. We should decide what's the rule and ways to allow emitter/user to see message at different level.
  • Proposed rules:
    • When dealing with KNOWN bad states, each emitter should use diagnostic report at the consistent level.
    • For UNKNOWN bad states, they are allow to throw which generates callstacks & display File a bug message.
  • Each emitter output same given an empty spec
  • Champion scenario specs & common known bad state specs should be checked into Spector http-spec for regression tracking

More to add?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants