Skip to content

Commit a0a4332

Browse files
authored
only return options if no args are provided (#239247)
fix #237598
1 parent ec485c8 commit a0a4332

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

extensions/terminal-suggest/src/terminalSuggestMain.ts

+8-6
Original file line numberDiff line numberDiff line change
@@ -368,12 +368,14 @@ export async function getCompletionItemsFromSpecs(
368368
filesRequested ||= argsCompletionResult.filesRequested;
369369
foldersRequested ||= argsCompletionResult.foldersRequested;
370370
}
371-
372-
const optionsCompletionResult = handleOptions(specLabel, spec, terminalContext, precedingText, prefix);
373-
if (optionsCompletionResult) {
374-
items.push(...optionsCompletionResult.items);
375-
filesRequested ||= optionsCompletionResult.filesRequested;
376-
foldersRequested ||= optionsCompletionResult.foldersRequested;
371+
if (!argsCompletionResult?.items.length) {
372+
// Arg completions are more specific, only get options if those are not provided.
373+
const optionsCompletionResult = handleOptions(specLabel, spec, terminalContext, precedingText, prefix);
374+
if (optionsCompletionResult) {
375+
items.push(...optionsCompletionResult.items);
376+
filesRequested ||= optionsCompletionResult.filesRequested;
377+
foldersRequested ||= optionsCompletionResult.foldersRequested;
378+
}
377379
}
378380
}
379381
}

0 commit comments

Comments
 (0)