Remove aria-activedescendant when typing & remove clearFocus code (#239857)

This applies some good feedback from @rperez030 in here:
#237324 (comment)

which gave me the idea to just remove `aria-activedescendant` whenever you type in the input box. This allows arrow keys and selections to read out.

Because of that, we can remove this SHIFT+TAB behavior I introduced a while back since that isn't needed to get the screen reader to read out the arrow keys.

Note: deletions in certain quick picks remain a challenge. Since deletion leads to a changed filter, which triggers the list to highlight something new, often deletions are overriden by the list changes. Honestly, even the SHIFT+TAB behavior before didn't improve the deletions... sometimes the screen reader read them, sometimes it didn't.

Fixes #180862

Author: TylerLeonhardt

src/vs/platform/quickinput/browser/quickInputBox.ts

@@ -4,8 +4,6 @@
  *--------------------------------------------------------------------------------------------*/
 
 import * as dom from '../../../base/browser/dom.js';
-import { StandardKeyboardEvent } from '../../../base/browser/keyboardEvent.js';
-import { StandardMouseEvent } from '../../../base/browser/mouseEvent.js';
 import { FindInput } from '../../../base/browser/ui/findinput/findInput.js';
 import { IInputBoxStyles, IRange, MessageType } from '../../../base/browser/ui/inputbox/inputBox.js';
 import { IToggleStyles, Toggle } from '../../../base/browser/ui/toggle/toggle.js';
@@ -34,13 +32,13 @@ export class QuickInputBox extends Disposable {
 		input.ariaAutoComplete = 'list';
 	}
 
-	onKeyDown = (handler: (event: StandardKeyboardEvent) => void): IDisposable => {
-		return dom.addStandardDisposableListener(this.findInput.inputBox.inputElement, dom.EventType.KEY_DOWN, handler);
-	};
+	get onKeyDown() {
+		return this.findInput.onKeyDown;
+	}
 
-	onMouseDown = (handler: (event: StandardMouseEvent) => void): IDisposable => {
-		return dom.addStandardDisposableListener(this.findInput.inputBox.inputElement, dom.EventType.MOUSE_DOWN, handler);
-	};
+	get onMouseDown() {
+		return this.findInput.onMouseDown;
+	}
 
 	onDidChange = (handler: (event: string) => void): IDisposable => {
 		return this.findInput.onDidChange(handler);

src/vs/platform/quickinput/browser/quickInputController.ts

@@ -262,6 +262,11 @@ export class QuickInputController extends Disposable {
 			if (this.endOfQuickInputBoxContext.get() !== value) {
 				this.endOfQuickInputBoxContext.set(value);
 			}
+			// Allow screenreaders to read what's in the input
+			// Note: this works for arrow keys and selection changes,
+			// but not for deletions since that often triggers a
+			// change in the list.
+			inputBox.removeAttribute('aria-activedescendant');
 		}));
 		this._register(dom.addDisposableListener(container, dom.EventType.FOCUS, (e: FocusEvent) => {
 			inputBox.setFocus();
@@ -313,15 +318,14 @@ export class QuickInputController extends Disposable {
 							selectors.push('.quick-input-html-widget');
 						}
 						const stops = container.querySelectorAll<HTMLElement>(selectors.join(', '));
-						if (event.shiftKey && event.target === stops[0]) {
-							// Clear the focus from the list in order to allow
-							// screen readers to read operations in the input box.
-							dom.EventHelper.stop(event, true);
-							list.clearFocus();
-						} else if (!event.shiftKey && dom.isAncestor(event.target, stops[stops.length - 1])) {
+						if (!event.shiftKey && dom.isAncestor(event.target, stops[stops.length - 1])) {
 							dom.EventHelper.stop(event, true);
 							stops[0].focus();
 						}
+						if (event.shiftKey && dom.isAncestor(event.target, stops[0])) {
+							dom.EventHelper.stop(event, true);
+							stops[stops.length - 1].focus();
+						}
 					}
 					break;
 			}