-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop renaming every variable in a project on F2. Look at the class and scope. #241352
Comments
Which language? |
Sorry. Java
…________________________________
From: John Murray ***@***.***>
Sent: Thursday, February 20, 2025 10:21 AM
To: microsoft/vscode ***@***.***>
Cc: Curtis Smith ***@***.***>; Author ***@***.***>
Subject: [Ext:] Re: [microsoft/vscode] Stop renaming every variable in a project on F2. Look at the class and scope. (Issue #241352)
[External Email]
Which language?
—
Reply to this email directly, view it on GitHub<#241352 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AS7XFXB2TR6FNI3AZPXTCPL2QYFKFAVCNFSM6AAAAABXRA2NBWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZSGE3DSMZXHA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
[gjsjohnmurray]gjsjohnmurray left a comment (microsoft/vscode#241352)<#241352 (comment)>
Which language?
—
Reply to this email directly, view it on GitHub<#241352 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AS7XFXB2TR6FNI3AZPXTCPL2QYFKFAVCNFSM6AAAAABXRA2NBWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZSGE3DSMZXHA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
/causedByExtension |
This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines. If you don't know which extension is causing the problem, you can run Happy Coding! |
Got it thanks. |
Does this issue occur when all extensions are disabled?: Yes
Steps to Reproduce:
Description:
vscode replaces every occurrence of a rename (F2) across the project. Please stop doing that or provide a better way to rename member variables. The current way isn't helpful. Is simply corrupts everything else that has the same variable name. You have the intelligence in the application to determine scope and the class the rename should apply to. Use that information to only apply the change to the member of the class for the scope it has. Currently you only change references to the name but not all of the classes that have members with that name. That breaks every one of those classes by disassociating it with its member variable.
The text was updated successfully, but these errors were encountered: