Differentiate flags/options, add option value type #241395
Open
+56
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes an issue where option values stopped working recently. Fixes #241392
|
Tests might fail |
meganrogge
reviewed
Feb 20, 2025
| @@ -66,7 +67,7 @@ export async function getFigSuggestions( | |||
| result.items.push(createCompletionItem( | |||
| terminalContext.cursorPosition, | |||
| prefix, | |||
| { label: { label: specLabel, description } }, | |||
| { label: { label: specLabel, description }, kind: vscode.TerminalCompletionItemKind.Flag }, | |||
There was a problem hiding this comment.
Shouldn't this be a Method, not a Flag?
meganrogge
reviewed
Feb 20, 2025
| @@ -238,6 +239,10 @@ export async function collectCompletionItemResult( | |||
| } | |||
| const flagsToExclude = kind === vscode.TerminalCompletionItemKind.Flag ? parsedArguments?.passedOptions.map(option => option.name).flat() : undefined; | |||
| if (Array.isArray(specArgs)) { | |||
| let itemKind = kind; | |||
| if (parsedArguments?.currentArg?.suggestions?.length === specArgs.length) { | |||
There was a problem hiding this comment.
Maybe a comment with an example of what specArgs and parsedArguments?.currentArg?.suggestions might be here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes an issue where option values stopped working recently.
Fixes #241392
Fixes #241412
We don't have the flag icon yet: