Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipelines should notify of manifest validation warnings on a PR #167559

Open
mdanish-kh opened this issue Aug 13, 2024 · 0 comments
Open

Pipelines should notify of manifest validation warnings on a PR #167559

mdanish-kh opened this issue Aug 13, 2024 · 0 comments
Labels
Area-Validation-Pipeline Issues related to the manifest validation pipeline. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.

Comments

@mdanish-kh
Copy link
Contributor

Description of the new feature/enhancement

When winget validate succeeds with warnings, the pipelines should ideally apply a label / add a comment notifying PR author and reviewers of the warnings.

Seen in #167554, where Moniker (only supported in defaultLocale manifests) was put in locale manifests and pipelines didn't warn about it

The winget validate output for above PR would've been

Manifest validation succeeded with warnings.
Manifest Warning: Unknown field. [Moniker]

Proposed technical implementation details (optional)

No response
@mdanish-kh mdanish-kh added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Aug 13, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Area-Validation-Pipeline Issues related to the manifest validation pipeline. Needs-Triage This work item needs to be triaged by a member of the core team. labels Aug 13, 2024
@stephengillie stephengillie removed the Needs-Triage This work item needs to be triaged by a member of the core team. label Aug 14, 2024
@Trenly Trenly mentioned this issue Feb 10, 2025
Closed
DuckDuckStudio added a commit to DuckDuckStudio/winget-pkgs that referenced this issue Feb 10, 2025
@DuckDuckStudio
Fix Manifest Error
e94579d 
See microsoft/winget-cli#5193 (comment)
Related to microsoft#167559
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Validation-Pipeline Issues related to the manifest validation pipeline. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdanish-kh @stephengillie