Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: JoeTaylor.WSJT-X version 2.7.0 #230631

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SpecterShell
Copy link
Contributor

@SpecterShell SpecterShell commented Feb 18, 2025

Resolves #230584

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Unapproved-URL labels Feb 18, 2025
@AsciiWolf
Copy link
Contributor

@SpecterShell @stephengillie The old package should probably also be moved under this new namespace.

@SpecterShell
Copy link
Contributor Author

@SpecterShell @stephengillie The old package should probably also be moved under this new namespace.

Uhh I thought that was a package request rather than an update request and I didn't know the package exists. Should I move that package to this one, or move this package to the old one?

@AsciiWolf
Copy link
Contributor

AsciiWolf commented Feb 18, 2025

I am not sure. It probably should follow the app developer/publisher name in the Windows Installer metadata.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Feb 18, 2025
@SpecterShell
Copy link
Contributor Author

I am not sure. It probably should follow the app developer/publisher name in the Windows Installer metadata.

Actually the publisher name of the installer is Joe Taylor, K1JT, both of which are the "names" of the same person, so it is pretty hard to decide which one to use. The latter one is used in the previous package.

The package name is WSJT-X though, upper-case with a hyphen.

@AsciiWolf
Copy link
Contributor

AsciiWolf commented Feb 18, 2025

Actually the publisher name of the installer is Joe Taylor, K1JT, both of which are the "names" of the same person, so it is pretty hard to decide which one to use. The latter one is used in the previous package.

It probably does not matter, but both packages should be moved under the same namespace (and the app name should also be adjusted so both packages are either "wsjtx" or "wsjt-x").

@SpecterShell
Copy link
Contributor Author

SpecterShell commented Feb 19, 2025

Actually the publisher name of the installer is Joe Taylor, K1JT, both of which are the "names" of the same person, so it is pretty hard to decide which one to use. The latter one is used in the previous package.

It probably does not matter, but both packages should be moved under the same namespace (and the app name should also be adjusted so both packages are either "wsjtx" or "wsjt-x").

Another package is being moved to this one in #231173 and #231174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Package Validation-Unapproved-URL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Update Request]: WSJT-X
5 participants