Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Package Issue]: martinvonz.jj and jj-vcs.jj appear to be the same package: #231752

Closed
stephengillie opened this issue Feb 20, 2025 · 2 comments · Fixed by #232033, #232013, #232031, #232015 or #232021
Closed
Labels
In-PR Package-Update This package needs to be updated

Comments

@stephengillie
Copy link
Collaborator

Steps to reproduce:

Possible duplicate package entry.

Similar installer SHA256 hash found in manifest:

  • InstallerSha256: 423d8cd4ae4167a9d550fc75f8d30d125aad1859be880ae972c4e529845fd849

    • manifests\j\jj-vcs\jj\0.26.0

These PackageIdentifiers should probably be merged.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label Feb 20, 2025
@stephengillie stephengillie added Help-Wanted This is a good candidate work item from the community. Package-Update This package needs to be updated and removed Needs-Triage This work item needs to be triaged by a member of the core team. labels Feb 21, 2025
@pranjalagg
Copy link
Contributor

@stephengillie
Both of these manifests have multiple versions tracked. How should it be decided which one to remove?
Should the one containing less versions be removed (jj-vcs.jj in this case)?

@Dragon1573
Copy link
Contributor

Both of these manifests have multiple versions tracked. How should it be decided which one to remove?

In my opinion, I would prefer squashing them to jj-vcs.jj. This is the package actually stored in the GitHub repository with its publisher account name and package name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment